Review TYPO3_4-6 Merged

6383[BUGFIX] Install Tool: Improper check of PHP session.auto_start

Markus Klein CR -1 V +2 Easy +10 −1 updated 06/03/13, 20:49

Commit message

This fix improves the check for the PHP session.auto_start configuration
to account also for valid Yes/No configuration values.

Review

  • Code review CR -1
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Markus Klein -1
    • Simon Schaufelberger +1
  • Verified V +2
    • Xavier Perseguers +2
    • Georg Ringer +1
    • Simon Schaufelberger +1

Files 2

Review log 7

  1. Stefan Neufeind commented on patch set 1 11/22/11, 14:10

    Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 1 11/22/11, 14:10

    Please vote in master first: https://review.typo3.org/6382 This will be taken care later on.
  3. Markus Klein commented on patch set 1 11/22/11, 14:10

    I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6382 This will be taken care later on.
  4. Georg Ringer commented on patch set 1 11/22/11, 14:10

    Verified; Looks good to me, but someone else must approve
  5. Simon Schaufelberger commented on patch set 1 11/22/11, 14:10

    Verified; Looks good to me, but someone else must approve
  6. Xavier Perseguers commented on patch set 1 V 0 11/22/11, 14:10

    by team member; Looks good to me, approved Backported from master
  7. Xavier Perseguers merged patch set 1 11/22/11, 14:10