63832[BUGFIX] Add guard clause while checking if user is system maintainer
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1115
-
Georg Ringer uploaded patch set 1 03/21/20, 20:32
-
Georg Ringer commented on patch set 1 03/21/20, 20:33
This change is ready for review. -
Georg Ringer updated the commit message in patch set 2 03/21/20, 20:35
-
Benni Mack voted on patch set 2 CR +1 03/21/20, 20:36
-
TYPO3com voted on patch set 1 V -1 03/21/20, 20:47 Completed build in 14m 44s on Sat, 21 Mar, 08:47 PM Test Summary: 8 of 72715 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1553
-
TYPO3com voted on patch set 2 V -1 03/21/20, 20:51 Completed build in 14m 17s on Sat, 21 Mar, 08:51 PM Test Summary: 8 of 72715 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1554
-
TYPO3com commented on patch set 2 03/21/20, 21:15 Completed build in 52m 37s on Sat, 21 Mar, 09:15 PM Test Summary: 8 of 72715 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1554
-
Andreas Kienast commented on patch set 2 CR -1 03/21/20, 21:30
BackendUserAuthentication.php:501UnresolvedThis is wrong, IMO. Since we guard this for non-admins, this must be "true" instead. -
Georg Ringer uploaded patch set 3 03/21/20, 21:40
-
TYPO3com voted on patch set 3 V +1 03/21/20, 21:52 Completed build in 11m 49s on Sat, 21 Mar, 09:52 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1559
-
Andreas Kienast voted on patch set 3 V +1 CR +1 03/21/20, 22:00
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 03/22/20, 08:28
-
Oliver Klee voted on patch set 3 CR +1 03/22/20, 12:08
-
Andreas Kienast voted on patch set 3 V +2 CR +2 03/22/20, 12:27
-
Andreas Kienast merged patch set 4 03/22/20, 12:27