Review main Merged

63833[BUGFIX] Check event.key for Install Tool submit

Georg Ringer CR +2 V +2 Easy +2 −2 updated 03/23/20, 07:38

Commit message

Use event.key instead of the discouraged event.keyCode.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Georg Ringer uploaded patch set 1 03/21/20, 21:04

  2. Georg Ringer commented on patch set 1 03/21/20, 21:04

    This change is ready for review.
  3. Andreas Kienast voted on patch set 1 CR -1 03/21/20, 21:09

  4. Andreas Kienast commented on patch set 1 03/21/20, 21:11

    Router.ts:42 Unresolved

    Both are discouraged to use, please check for `e.key === 'Enter'` instead.
  5. Georg Ringer uploaded patch set 2 03/21/20, 21:16

  6. TYPO3com voted on patch set 1 V +1 03/21/20, 21:18 Completed build in 13m 31s on Sat, 21 Mar, 09:18 PM Test Summary: 72229 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1555

  7. Andreas Kienast updated the commit message in patch set 3 03/21/20, 21:21

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 03/21/20, 21:21

  9. TYPO3com voted on patch set 2 V +1 03/21/20, 21:27 Completed build in 11m 34s on Sat, 21 Mar, 09:27 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1556

  10. TYPO3com voted on patch set 3 V +1 03/21/20, 21:34 Completed build in 12m 21s on Sat, 21 Mar, 09:34 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1557

  11. Susi Moog voted on patch set 3 V +2 CR +2 03/23/20, 07:38

  12. Susi Moog merged patch set 4 03/23/20, 07:38