Review main Merged

63838[BUGFIX] Keep order of selection on importing assets

Andreas Kienast CR +2 V +2 Normal +64 −21 updated 03/23/20, 11:41

Commit message

If assets get imported via mass selection in the Element Browser, the
order of the items is now kept. Since this requires interframe
communication, the Inline Control Container now sends a postMessage to
the Element Browser.

When the import process starts, the first asset of the selection gets
imported. After the import, the postMessage is intercepted and the next
asset get imported, until the queue is empty. As this could be a rather
lenghty process, a progress bar is rendered at the top of the file
table.

To get a more fitting naming, all previously used action names used in
postMessages have been renamed from `typo3:foreignRelation:inserted` to
`typo3:foreignRelation:insert`.

As a drive-by fix, the server is not spammed with n request anymore due
to queueing.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 11

Review log 814

  1. Andreas Kienast uploaded patch set 1 03/22/20, 08:09

  2. TYPO3com voted on patch set 1 V +1 03/22/20, 08:21 Completed build in 11m 37s on Sun, 22 Mar, 08:21 AM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1567

  3. Andreas Kienast uploaded patch set 2 03/22/20, 10:57

  4. TYPO3com voted on patch set 2 V -1 03/22/20, 11:10 Completed build in 12m 38s on Sun, 22 Mar, 11:10 AM Test Summary: 62003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1569

  5. TYPO3com voted on patch set 2 V +1 03/22/20, 11:39 Completed build in 54m 02s on Sun, 22 Mar, 11:39 AM Test Summary: 72229 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1569

  6. Andreas Kienast updated the commit message in patch set 3 03/22/20, 11:46

  7. Susi Moog voted on patch set 3 V +1 CR +1 03/22/20, 11:50

  8. TYPO3com voted on patch set 3 V -1 03/22/20, 11:58 Completed build in 11m 40s on Sun, 22 Mar, 11:58 AM Test Summary: 72222 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1571

  9. TYPO3com voted on patch set 3 V +1 03/22/20, 12:29 Completed build in 54m 37s on Sun, 22 Mar, 12:29 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1571

  10. Susi Moog updated the commit message in patch set 4 03/23/20, 07:08

  11. Susi Moog voted on patch set 4 V +1 CR +1 03/23/20, 07:13

  12. TYPO3com voted on patch set 4 V +1 03/23/20, 07:25 Completed build in 16m 30s on Mon, 23 Mar, 07:25 AM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1595

  13. Daniel Goerz voted on patch set 4 V +2 CR +2 03/23/20, 11:41

  14. Daniel Goerz merged patch set 5 03/23/20, 11:41