Review main Merged

63846[TASK] Require friendsoftypo3/phpstan-typo3

Alexander Schnitzler CR +2 V +2 Hard +317 −97 updated 03/23/20, 11:20

Commit message

Used command:

    composer require friendsoftypo3/phpstan-typo3:"~0.2" --dev

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 710

  1. Alexander Schnitzler uploaded patch set 1 03/22/20, 17:19

  2. Alexander Schnitzler wrote 03/22/20, 17:19

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 03/22/20, 17:30 Completed build in 11m 27s on Sun, 22 Mar, 05:30 PM Test Summary: 71941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1586

  4. TYPO3com voted on patch set 1 V +1 03/22/20, 17:58 Completed build in 50m 58s on Sun, 22 Mar, 05:58 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1586

  5. Alexander Schnitzler updated the commit message in patch set 2 03/22/20, 18:12

  6. TYPO3com voted on patch set 2 V +1 03/22/20, 18:23 Completed build in 10m 57s on Sun, 22 Mar, 06:23 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1587

  7. Oliver Klee voted on patch set 2 CR +1 03/22/20, 20:36

  8. Georg Ringer voted on patch set 2 V +1 CR +1 03/23/20, 06:18

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 03/23/20, 11:20

  10. Daniel Goerz merged patch set 3 03/23/20, 11:20