63847[TASK] Decouple BackendLayoutRenderer/RecordRememberer from BackendLayout
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php5+6 −4
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+4 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+0 −2
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+3 −15
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+7 −2
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+13 −7
Review log 912
-
Benni Mack uploaded patch set 1 03/22/20, 21:00
-
TYPO3com voted on patch set 1 V -1 03/22/20, 21:12 Completed build in 12m 01s on Sun, 22 Mar, 09:12 PM Test Summary: 2 of 72715 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1591
-
Benni Mack uploaded patch set 2 03/22/20, 21:13
-
Benni Mack uploaded patch set 3 03/22/20, 21:18
-
TYPO3com voted on patch set 2 V +1 03/22/20, 21:26 Completed build in 13m 05s on Sun, 22 Mar, 09:26 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1592
-
TYPO3com voted on patch set 3 V +1 03/22/20, 21:31 Completed build in 11m 56s on Sun, 22 Mar, 09:30 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1593
-
Claus Due commented on patch set 3 03/23/20, 07:54
-
Benni Mack commented on patch set 3 03/23/20, 08:57
PageLayoutController.php:648ReplyOK. but then we should have a factory in place for that and decouple it like this. Having third-party BackendLayout types also brings to me the question that we would probably rather have an interface. The DrawingConfiguration is currently the behaviour of the page layout module rendering, if we go with "custom backend layouts" I would heavily reduce the "per-BackendLayoutConfiguration" into a custom class and have the current "Page-layout module configuration" class extend from that? -
Claus Due commented on patch set 3 03/23/20, 09:14
PageLayoutController.php:648ReplyThis would happen sort of naturally if we go in the "content grids" direction. In phase 4 of my proposed plan we would have a situation where none of these things are necessary anymore - my advise would be to not put this much effort into it, since we may be no more than six months away from deprecating those parts. When they are deprecated we would naturally extract the DrawingConfiguration, PageLayoutRenderer and ContentFetcher - but until that time we may actually *require* that they are provided by BackendLayout since this gives us a nice "opt-in" type separation between old BackendLayouts and new "content grid" approach. I still don't think we should be looking in the direction of refactoring or adding contract interfaces for these older parts. I think we would be better off focusing on replacing the static idea of BackendLayout with "content grids" as proposed in my plan. -
Benni Mack commented on patch set 3 03/23/20, 13:11
PageLayoutController.php:648ReplyOK. I understand, but as far as I understand you're saying: we're now "making BackendLayout fat" so extension authors can provide their own BackendLayout implementation and configuration to reduce it later-on in v11 again? Just trying to get the implications -
Claus Due commented on patch set 3 03/23/20, 14:51
PageLayoutController.php:648Reply UnresolvedIn a way, yes - but not only for extension authors, also for segmentation of features in TYPO3 itself. End goal is to remove, not reduce, the current backend layout practices in favor of a dynamically managed grid system. We make it fat first for encapsulation purposes, then we make it optional and only necessary in legacy systems, finally we remove it. -
Benni Mack abandoned the change 03/29/20, 12:17
won't continue here. can be abandoned.
PageLayoutController.php:648