Review main Merged

63848[TASK] Provide test for Page\TreeController

Tymoteusz Motylewski CR +2 V +2 Hard +583 −12 updated 05/11/20, 09:51

Commit message

Add test for TreeController, so we're safe when refactoring
or doing performance optimizations.

Besides that moved pages in a workspace were not considered when
calculating permissions on the rootline due to missing workspace
overlays.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 3255

Show 1530 earlier messages
  1. Tymoteusz Motylewski uploaded patch set 1 03/22/20, 21:59

  2. TYPO3com voted on patch set 1 V -1 03/22/20, 22:00 Completed build in 25s on Sun, 22 Mar, 10:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1594

  3. Tymoteusz Motylewski uploaded patch set 2 03/24/20, 20:27

  4. TYPO3com voted on patch set 2 V -1 03/24/20, 20:29 Completed build in 19s on Tue, 24 Mar, 08:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1682

  5. Tymoteusz Motylewski uploaded patch set 3 03/24/20, 20:32

  6. Tymoteusz Motylewski uploaded patch set 4 03/24/20, 20:34

  7. TYPO3com voted on patch set 3 V -1 03/24/20, 20:44 Completed build in 09m 23s on Tue, 24 Mar, 08:44 PM Test Summary: 62754 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1683

  8. TYPO3com voted on patch set 4 V -1 03/24/20, 20:47 Completed build in 11m 48s on Tue, 24 Mar, 08:47 PM Test Summary: 62754 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1684

  9. Tymoteusz Motylewski uploaded patch set 5 03/25/20, 13:25

  10. TYPO3com voted on patch set 5 V -1 03/25/20, 13:36 Completed build in 10m 44s on Wed, 25 Mar, 01:36 PM Test Summary: 65 of 73505 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1708

  11. Tymoteusz Motylewski uploaded patch set 6 03/26/20, 20:46

  12. TYPO3com voted on patch set 6 V -1 03/26/20, 21:00 Completed build in 13m 05s on Thu, 26 Mar, 09:00 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1800

  13. Tymoteusz Motylewski uploaded patch set 7 03/26/20, 21:09

  14. TYPO3com voted on patch set 7 V +1 03/26/20, 21:25 Completed build in 15m 50s on Thu, 26 Mar, 09:25 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1801

  15. Tymoteusz Motylewski uploaded patch set 8 03/28/20, 07:14

  16. TYPO3com voted on patch set 8 V +1 03/28/20, 07:26 Completed build in 11m 44s on Sat, 28 Mar, 07:26 AM Test Summary: 73047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1877

  17. Tymoteusz Motylewski uploaded patch set 9 03/28/20, 08:33

  18. Tymoteusz Motylewski updated the commit message in patch set 10 03/28/20, 08:39

  19. TYPO3com voted on patch set 9 V +1 03/28/20, 08:51 Completed build in 18m 09s on Sat, 28 Mar, 08:51 AM Test Summary: 73047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1882

  20. TYPO3com voted on patch set 10 V +1 03/28/20, 08:55 Completed build in 13m 53s on Sat, 28 Mar, 08:55 AM Test Summary: 73047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1884

  21. Tymoteusz Motylewski uploaded patch set 11 03/29/20, 09:39

  22. TYPO3com voted on patch set 11 V +1 03/29/20, 09:54 Completed build in 14m 31s on Sun, 29 Mar, 09:54 AM Test Summary: 73053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1923

  23. Tymoteusz Motylewski uploaded patch set 12 03/30/20, 06:39

  24. TYPO3com voted on patch set 12 V -1 03/30/20, 06:39 Completed build in 10s on Mon, 30 Mar, 06:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1938

  25. Tymoteusz Motylewski uploaded patch set 13 03/30/20, 10:55

  26. TYPO3com voted on patch set 13 V -1 03/30/20, 10:55 Completed build in 26s on Mon, 30 Mar, 10:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1953

  27. Tymoteusz Motylewski rebased onto patch set 14 03/30/20, 21:32

  28. TYPO3com voted on patch set 14 V -1 03/30/20, 21:33 Completed build in 39s on Mon, 30 Mar, 09:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1991

  29. Tymoteusz Motylewski uploaded patch set 15 04/04/20, 12:40

  30. TYPO3com voted on patch set 15 V +1 04/04/20, 12:56 Completed build in 13m 58s on Sat, 4 Apr, 12:56 PM Test Summary: 73294 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2160

  1. Oliver Hader uploaded patch set 16 04/06/20, 11:34

  2. Oliver Hader commented on patch set 16 04/06/20, 11:34

    Resolved merge conflict, adjusted TreeController initialization based on Context & UserAspect
  3. TYPO3com voted on patch set 16 V +1 04/06/20, 11:51 Completed build in 15m 08s on Mon, 6 Apr, 11:51 AM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2228

  4. Oliver Hader uploaded patch set 17 04/06/20, 14:06

  5. TYPO3com voted on patch set 17 V -1 04/06/20, 14:28 Completed build in 22m 39s on Mon, 6 Apr, 02:28 PM Test Summary: 3 of 73856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2231

  6. Oliver Hader uploaded patch set 18 04/06/20, 15:21

  7. TYPO3com voted on patch set 18 V -1 04/06/20, 16:00 Completed build in 33m 15s on Mon, 6 Apr, 04:00 PM Test Summary: 3 of 73856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2234

  8. Oliver Hader uploaded patch set 19 04/07/20, 09:57

  9. TYPO3com voted on patch set 19 V -1 04/07/20, 10:09 Completed build in 12m 13s on Tue, 7 Apr, 10:09 AM Test Summary: 3 of 73215 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2266

  10. Oliver Hader uploaded patch set 20 04/07/20, 10:44

  11. TYPO3com voted on patch set 20 V -1 04/07/20, 10:59 Completed build in 14m 37s on Tue, 7 Apr, 10:59 AM Test Summary: 3 of 73853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2271

  12. Oliver Hader uploaded patch set 21 04/07/20, 11:09

  13. TYPO3com voted on patch set 21 V +1 04/07/20, 11:22 Completed build in 12m 25s on Tue, 7 Apr, 11:22 AM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2273

  14. Tymoteusz Motylewski updated the commit message in patch set 22 04/08/20, 11:21

  15. TYPO3com voted on patch set 22 V +1 04/08/20, 12:05 Completed build in 26m 10s on Wed, 8 Apr, 12:05 PM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2295

  16. Oliver Hader voted on patch set 22 V +1 CR +1 04/08/20, 14:08

  17. Daniel Goerz voted on patch set 22 CR +1 04/08/20, 19:41

  18. Tymoteusz Motylewski updated the commit message in patch set 23 04/08/20, 20:49

  19. Tymoteusz Motylewski commented on patch set 23 04/08/20, 20:49

    changed commit message - removed obsolete part
  20. TYPO3com voted on patch set 23 V +1 04/08/20, 21:02 Completed build in 13m 41s on Wed, 8 Apr, 09:02 PM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2331

  21. Oliver Hader voted on patch set 23 V +1 CR +1 04/08/20, 21:19

  22. Oliver Hader voted on patch set 23 V +2 CR +2 04/09/20, 07:40

  23. Oliver Hader merged patch set 24 04/09/20, 07:40

  24. Benni Mack commented on patch set 24 05/11/20, 09:41

    BackendUserAuthentication.php:416

    this change actually breaks pagetree w/ editors in workspace
  25. Oliver Hader commented on patch set 24 05/11/20, 09:51

    BackendUserAuthentication.php:416 Reply Unresolved

    How exactly? The change was introduced for move-placeholders being resolved... if it breaks it means the tests are wrong as well...