Review 9.5 Merged

63851[TASK] Set pseudo user when simulating a user group

Susi Moog CR +2 V +2 Easy +3 −1 updated 03/24/20, 19:23

Commit message

Simulating a user group had no user set, which resulted in some things
not being simulated (for example the fluid `role` and `authenticated`
view helpers).

As the expectation just includes a `uid` > 0, we are now setting
`uid=1` for the simulated user. However, the long term solution for
future versions should be replacing the usergroup simulation by a
simulation of a concrete user (like impersonating is done in the
backend).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Henrik Ziegenhain +1
  • Verified V +2 Done
    • Benni Mack +2
    • Henrik Ziegenhain +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Susi Moog uploaded patch set 1 03/23/20, 08:27

  2. Susi Moog commented on patch set 1 CR -2 03/23/20, 08:27

    pending master submit.
  3. TYPO3com voted on patch set 1 V +1 03/23/20, 08:44 Completed build in 13m 35s on Mon, 23 Mar, 08:44 AM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-316

  4. Henrik Ziegenhain commented on patch set 1 V +1 CR +1 03/23/20, 08:52

    Thanks Susi, works like a charm for 9.5
  5. Susi Moog commented on patch set 2 03/23/20, 15:26

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 03/23/20, 15:38 Completed build in 11m 54s on Mon, 23 Mar, 03:38 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-327

  7. Henrik Ziegenhain commented on patch set 2 V +1 CR +1 03/24/20, 04:20

    This user ID is OK for me :-)
  8. Susi Moog wrote 03/24/20, 12:39

    Removed Code-Review-2 by Susanne Moog <look@susi.dev>
  9. Susi Moog commented on patch set 2 03/24/20, 12:39

    This change is ready for review.
  10. Benni Mack voted on patch set 2 V +2 CR +2 03/24/20, 19:23

  11. Benni Mack merged patch set 3 03/24/20, 19:23