Review 9.5 Merged

63852[BUGFIX] Do not overwrite default thread count for Argon PasswordHashing

Benni Mack CR +2 V +2 Easy +5 −3 updated 03/22/20, 21:00

Commit message

There are systems and library combinations that do not allow the usage
of more than one thread to generate passwords. To ensure maximum
compatibility, the number of threads is reset to its default state.

If raising the number makes sense for performance reasons on systems
that support it, the setting can still be overwritten by setting
`$GLOBALS['TYPO3_CONF_VARS']['BE']['passwordHashing']['options']['threads']`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 03/22/20, 19:04

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Crypto/PasswordHashing/AbstractArgon2PasswordHash.php
  2. TYPO3com voted on patch set 1 V -1 03/22/20, 19:06 Completed build in 31s on Sun, 22 Mar, 07:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-310

  3. Benni Mack uploaded patch set 2 03/22/20, 19:08

  4. TYPO3com voted on patch set 2 V +1 03/22/20, 19:24 Completed build in 13m 12s on Sun, 22 Mar, 07:24 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-311

  5. Benni Mack commented on patch set 2 V +2 CR +2 03/22/20, 21:00

    This change is ready for review.
  6. Benni Mack merged patch set 3 03/22/20, 21:00