Review 9.5 Merged

63860[BUGFIX] Hide the preview button for sysfolders in list/page layout module

Daniel Goerz CR +2 V +2 Easy +20 −1 updated 03/23/20, 13:39

Commit message

In the list view of a sysfolder, users could still see the page preview
button. The list view is now using the same logic as the page module
and the EditDocumentController, that allows for excluding some doktypes
from showing the preview button.

By default, the page types Recycler, Sysfolder and Spacer are excluded.
This behaviour can be overridden by setting the already available
pageTSconfig "TCEMAIN.preview.disableButtonForDokType".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 03/23/20, 13:23

    Cherry Picked from branch master.
  2. Daniel Goerz voted on patch set 1 V +2 CR +2 03/23/20, 13:25

  3. TYPO3com voted on patch set 1 V +1 03/23/20, 13:38 Completed build in 13m 01s on Mon, 23 Mar, 01:38 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-325

  4. Daniel Goerz merged patch set 2 03/23/20, 13:39