Review 9.5 Merged

63861[BUGFIX] Properly display boolean values as "0" and "1" in strings

Daniel Goerz CR +2 V +2 Easy +7 −6 updated 03/24/20, 16:49

Commit message

The previous implementation used two typecasts in a row: from bool
to string, and from string to bool again. This caused a boolean
false to be cast first to null and then to an empty string instead
of to "0".

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 03/23/20, 15:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/23/20, 15:14 Completed build in 11m 53s on Mon, 23 Mar, 03:14 PM Test Summary: 74442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-326

  3. Benni Mack voted on patch set 1 V +2 CR +2 03/24/20, 16:49

  4. Benni Mack merged patch set 2 03/24/20, 16:49