Review 9.5 Merged

63868[BUGFIX] Set correct PID for inline elements on page object

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 03/24/20, 07:00

Commit message

The getDefaultUploadFolder hook must get the PID for the current
page if the inline element is located on a page object.

The logic is now as follows:
- In case of records that are stored on a page, $pid is the uid of
that page (pid of the record)
- In case of an existing page $pid is the current page uid
- In case of a new page, $pid is the relative page id as used in other
places (for example -224 for a page below page id 224) - this allows
hook implementations to react accordingly

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 03/24/20, 06:39

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/24/20, 06:52 Completed build in 12m 47s on Tue, 24 Mar, 06:52 AM Test Summary: 74108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-335

  3. TYPO3com voted on patch set 1 V +1 03/24/20, 07:00 Completed build in 33m 05s on Tue, 24 Mar, 07:00 AM Test Summary: 74448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-335

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 03/24/20, 07:00

  5. Andreas Kienast merged patch set 2 03/24/20, 07:00