Review main Merged

63880[BUGFIX] Allow existing page module hooks to modify record argument

Benni Mack CR +2 V +2 Easy +7 −0 updated 03/24/20, 06:33

Commit message

The existing drawItem_* hooks modified the record data to include custom
values to be used in previews.

The GridColumnItem now needs to allow to set the record data again.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 03/23/20, 15:37

  2. TYPO3com voted on patch set 1 V +1 03/23/20, 15:51 Completed build in 14m 08s on Mon, 23 Mar, 03:51 PM Test Summary: 72224 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1632

  3. Oli Bartsch voted on patch set 1 CR +1 03/23/20, 17:20

  4. Susi Moog voted on patch set 1 V +1 CR +1 03/23/20, 17:36

  5. Georg Ringer commented on patch set 2 03/23/20, 19:18

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 03/23/20, 19:30 Completed build in 11m 28s on Mon, 23 Mar, 07:30 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1637

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/23/20, 20:14

  8. Susi Moog voted on patch set 2 V +2 CR +2 03/24/20, 06:33

  9. Susi Moog merged patch set 3 03/24/20, 06:33