Review main Merged

63881[TASK] Allow workspace preview links independent of backend users

Benni Mack CR +2 V +2 Normal +44 −15 updated 03/24/20, 07:15

Commit message

Current implementation for defining a maximum lifetime of a workspace-related
previewlink is based on userTSconfig - which actually relies on the user configuration
that creates the preview link. This can lead to massive side effects.

The option is therefore added to each workspace with a default value of "48 hours",
to properly define the lifetime on a per-workspace and not on a
"per-user-who-generated the links" basis.

Actual features will be to add a GUI to the workspace module and see currently
working preview links. The UserTSconfig option should be marked as
deprecated in further iterations together with the new GUI feature.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 712

  1. Benni Mack uploaded patch set 1 03/23/20, 16:17

  2. Benni Mack updated the commit message in patch set 2 03/23/20, 16:18

  3. TYPO3com voted on patch set 1 V +1 03/23/20, 16:29 Completed build in 11m 02s on Mon, 23 Mar, 04:29 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1634

  4. TYPO3com voted on patch set 2 V +1 03/23/20, 16:34 Completed build in 16m 12s on Mon, 23 Mar, 04:34 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1635

  5. Benni Mack updated the commit message in patch set 3 03/23/20, 20:07

  6. TYPO3com voted on patch set 3 V +1 03/23/20, 20:34 Completed build in 24m 14s on Mon, 23 Mar, 08:34 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1648

  7. Susi Moog uploaded patch set 4 03/24/20, 06:31

  8. Susi Moog voted on patch set 4 V +1 CR +1 03/24/20, 06:31

  9. TYPO3com voted on patch set 4 V -1 03/24/20, 06:45 Completed build in 13m 18s on Tue, 24 Mar, 06:45 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1655

  10. TYPO3com voted on patch set 4 V +1 03/24/20, 06:54 Completed build in 36m 25s on Tue, 24 Mar, 06:54 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1655

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 03/24/20, 07:14

  12. Andreas Kienast merged patch set 5 03/24/20, 07:15