Review main Merged

63886[TASK] Use FluidEmail to send password recovery mail

Tobi Kretschmann CR +2 V +2 Hard +355 −263 updated 04/17/20, 22:41

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 8

Review log 4875

Show 3250 earlier messages
  1. Tobi Kretschmann uploaded patch set 1 03/23/20, 22:48

  2. Tobi Kretschmann uploaded patch set 2 03/23/20, 22:50

  3. Tobi Kretschmann uploaded patch set 3 03/23/20, 22:53

  4. TYPO3com voted on patch set 1 V -1 03/23/20, 22:59 Completed build in 11m 28s on Mon, 23 Mar, 10:59 PM Test Summary: 2386 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1652

  5. TYPO3com voted on patch set 2 V -1 03/23/20, 23:04 Completed build in 14m 38s on Mon, 23 Mar, 11:04 PM Test Summary: 2207 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1653

  6. TYPO3com voted on patch set 3 V -1 03/23/20, 23:08 Completed build in 12m 58s on Mon, 23 Mar, 11:08 PM Test Summary: 4670 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1654

  7. Tobi Kretschmann uploaded patch set 4 03/24/20, 08:16

  8. TYPO3com voted on patch set 4 V -1 03/24/20, 08:27 Completed build in 11m 14s on Tue, 24 Mar, 08:27 AM Test Summary: 3056 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1657

  9. Tobi Kretschmann uploaded patch set 5 03/24/20, 20:02

  10. TYPO3com voted on patch set 5 V -1 03/24/20, 20:23 Completed build in 20m 06s on Tue, 24 Mar, 08:23 PM Test Summary: 24 of 73474 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1680

  11. Tobi Kretschmann uploaded patch set 6 03/24/20, 21:04

  12. TYPO3com voted on patch set 6 V -1 03/24/20, 21:22 Completed build in 18m 47s on Tue, 24 Mar, 09:22 PM Test Summary: 36 of 73196 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1685

  13. Tobi Kretschmann uploaded patch set 7 03/25/20, 07:44

  14. TYPO3com voted on patch set 7 V -1 03/25/20, 07:56 Completed build in 11m 27s on Wed, 25 Mar, 07:56 AM Test Summary: 30 of 73507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1692

  15. Tobi Kretschmann uploaded patch set 8 03/29/20, 19:33

  16. TYPO3com voted on patch set 8 V -1 03/29/20, 19:34 Completed build in 23s on Sun, 29 Mar, 07:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1932

  17. Tobi Kretschmann updated the commit message in patch set 9 03/29/20, 19:34

  18. TYPO3com voted on patch set 9 V -1 03/29/20, 19:35 Completed build in 23s on Sun, 29 Mar, 07:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1933

  19. Tobi Kretschmann uploaded patch set 10 03/29/20, 19:42

  20. TYPO3com voted on patch set 10 V -1 03/29/20, 19:53 Completed build in 11m 36s on Sun, 29 Mar, 07:53 PM Test Summary: 6 of 73546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1934

  21. Tobi Kretschmann uploaded patch set 11 03/29/20, 19:57

  22. TYPO3com voted on patch set 11 V +1 03/29/20, 20:09 Completed build in 11m 44s on Sun, 29 Mar, 08:09 PM Test Summary: 73062 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1935

  23. Georg Ringer commented on patch set 11 CR -1 03/30/20, 04:41

    If it is a feature it needs an rst. I would change it to task and add some lines to the original rst including that it uses fluidEmail and an example how to configure those paths. Please don't use block mode for arguments at methods
  24. Tobi Kretschmann uploaded patch set 12 03/30/20, 08:30

  25. TYPO3com voted on patch set 12 V -1 03/30/20, 08:41 Completed build in 10m 40s on Mon, 30 Mar, 08:41 AM Test Summary: 72760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1942

  26. TYPO3com voted on patch set 12 V +1 03/30/20, 08:55 Completed build in 10m 39s on Mon, 30 Mar, 08:55 AM Test Summary: 73068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1943

  27. Tobi Kretschmann uploaded patch set 13 03/30/20, 09:21

  28. TYPO3com voted on patch set 13 V +1 03/30/20, 09:32 Completed build in 11m 52s on Mon, 30 Mar, 09:32 AM Test Summary: 73068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1947

  29. Manuel Selbach voted on patch set 13 CR +1 03/31/20, 20:36

  30. Jan Stockfisch commented on patch set 13 04/01/20, 08:29

    constants.typoscript:4 Unresolved

    Isn't this breaking / a regression for third party constants?
  31. Jan Stockfisch voted on patch set 13 CR -1 04/01/20, 08:33

  32. Tobi Kretschmann uploaded patch set 14 04/01/20, 08:41

  33. Tobi Kretschmann uploaded patch set 15 04/01/20, 08:44

  34. TYPO3com voted on patch set 14 V -1 04/01/20, 08:54 Completed build in 12m 11s on Wed, 1 Apr, 08:54 AM Test Summary: 16 of 73548 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2046

  35. TYPO3com voted on patch set 15 V +1 04/01/20, 08:58 Completed build in 14m 05s on Wed, 1 Apr, 08:58 AM Test Summary: 73062 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2047

  36. Jan Stockfisch voted on patch set 15 CR +1 04/01/20, 09:06

  37. Benni Mack commented on patch set 15 04/13/20, 10:32

    Looks good otherwise

    PasswordRecovery.html:1 Unresolved

    I wouldn't use the "SystemEmail" layout (have multi-site setups), but let's rather just use a custom layout only used in EXT:felogin for now.
  38. Tobi Kretschmann uploaded patch set 16 04/14/20, 14:40

  39. TYPO3com voted on patch set 16 V +1 04/14/20, 14:52 Completed build in 11m 39s on Tue, 14 Apr, 02:52 PM Test Summary: 73484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2511

  40. Georg Ringer commented on patch set 16 04/14/20, 15:04

    Feature-88110-FeloginExtbasePasswordRecovery.rst:62 Unresolved

    can we be in sync and have a space before {, also below

    RecoveryService.php:162 Unresolved

    please don't do that, we use single spaces

    constants.typoscript:4

    should we use Email there as well? also below

    RecoveryConfigurationTest.php:55 Unresolved

    single spaces only please
  41. Georg Ringer voted on patch set 16 CR -1 04/14/20, 15:04

  42. Tobi Kretschmann commented on patch set 16 04/14/20, 16:45

    constants.typoscript:4 Reply Unresolved

    this would actually be considered breaking since piBase uses this category as well.
  43. Tobi Kretschmann commented on patch set 17 04/14/20, 16:51

    Published edit on patch set 16.
  44. TYPO3com voted on patch set 17 V +1 04/14/20, 17:09 Completed build in 15m 44s on Tue, 14 Apr, 05:09 PM Test Summary: 73532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2521

  45. Georg Ringer voted on patch set 17 V +1 CR +1 04/14/20, 17:36

  46. Björn Jacob commented on patch set 17 CR -1 04/14/20, 21:51

    Some nitpicks and proof reading of the changelog.
    Let's start with a capital letter. "Use"
    Drop this line ;)

    Feature-88110-FeloginExtbasePasswordRecovery.rst:50

    "TypoScript"

    Feature-88110-FeloginExtbasePasswordRecovery.rst:51

    "an HTML"

    Feature-88110-FeloginExtbasePasswordRecovery.rst:53

    "TypoScript"

    Feature-88110-FeloginExtbasePasswordRecovery.rst:56

    add "the" -> "the configuration can be..."

    constants.typoscript:32

    "Reply to"

    constants.typoscript:32

    "Reply to"
  47. Tobi Kretschmann updated the commit message in patch set 18 04/14/20, 21:57

  48. Tobi Kretschmann commented on patch set 19 04/14/20, 22:01

    Published edit on patch set 18.
  49. Tobi Kretschmann commented on patch set 19 04/14/20, 22:05

    Reply

    Done

    Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:50 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:51 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:53 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:56 Reply

    Done

    constants.typoscript:32 Reply

    Done

    constants.typoscript:32 Reply

    Done
  50. Björn Jacob commented on patch set 19 04/14/20, 22:06

    Final stuff, of to bed now ;) Thx for taking care!

    Feature-88110-FeloginExtbasePasswordRecovery.rst:56

    IMHO this has to be "The".

    Feature-88110-FeloginExtbasePasswordRecovery.rst:64

    Can we remove the whitespaces?

    Feature-88110-FeloginExtbasePasswordRecovery.rst:92

    Not necesssary, but there should be an additional newline. Most of the docs do so IMHO.
  1. TYPO3com voted on patch set 18 V +1 04/14/20, 22:10 Completed build in 12m 42s on Tue, 14 Apr, 10:10 PM Test Summary: 73532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2540

  2. TYPO3com voted on patch set 19 V +1 04/14/20, 22:15 Completed build in 13m 45s on Tue, 14 Apr, 10:15 PM Test Summary: 73532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2541

  3. Björn Jacob commented on patch set 20 04/15/20, 06:25

    Published edit on patch set 19.
  4. Björn Jacob commented on patch set 20 CR +1 04/15/20, 06:26

    Fixed the issues. Improved the rst a bit. I am happy now :)

    Feature-88110-FeloginExtbasePasswordRecovery.rst:56 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:64 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:92 Reply

    Done
  5. TYPO3com voted on patch set 20 V +1 04/15/20, 06:38 Completed build in 12m 42s on Wed, 15 Apr, 06:38 AM Test Summary: 73531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2547

  6. Georg Ringer voted on patch set 20 V +1 CR +1 04/17/20, 06:58

  7. Markus Klein commented on patch set 20 V -1 CR -1 04/17/20, 07:19

    Feature-88110-FeloginExtbasePasswordRecovery.rst:60

    indentation space missing

    Feature-88110-FeloginExtbasePasswordRecovery.rst:82

    indentation space missing
  8. Markus Klein commented on patch set 20 04/17/20, 07:20

    RecoveryConfiguration.php:111

    I think we don't do that
  9. Markus Klein commented on patch set 20 04/17/20, 07:22

    PasswordRecovery.html:1

    why removing this?
  10. Tobi Kretschmann commented on patch set 20 04/17/20, 09:49

    RecoveryConfiguration.php:111 Reply

    Why don't we do that?
  11. Tobi Kretschmann commented on patch set 21 04/17/20, 10:58

    Published edit on patch set 20.
  12. TYPO3com voted on patch set 21 V -1 04/17/20, 11:16 Completed build in 14m 03s on Fri, 17 Apr, 11:16 AM Test Summary: 73573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2713

  13. TYPO3com commented on patch set 21 04/17/20, 11:46 Completed build in 11m 22s on Fri, 17 Apr, 11:46 AM Test Summary: 73573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2715

  14. Markus Klein commented on patch set 21 04/17/20, 12:05

    RecoveryConfiguration.php:111 Reply

    AFAIK the core team decided that some time ago to have consistent syntax in the whole core.
  15. Tobi Kretschmann commented on patch set 21 04/17/20, 13:02

    Feature-88110-FeloginExtbasePasswordRecovery.rst:60 Reply

    Done

    Feature-88110-FeloginExtbasePasswordRecovery.rst:82 Reply

    Done

    RecoveryConfiguration.php:111 Reply Unresolved

    oh, you mean the Backslash. I thought you mean the array_replace_recursive :) Sorry, my bad

    PasswordRecovery.html:1 Reply

    Done
  16. Tobi Kretschmann commented on patch set 22 04/17/20, 13:03

    Published edit on patch set 21.
  17. TYPO3com voted on patch set 22 V -1 04/17/20, 13:15 Completed build in 12m 03s on Fri, 17 Apr, 01:15 PM Test Summary: 73573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2722

  18. Andreas Kienast commented on patch set 23 04/17/20, 14:05

    Published edit on patch set 22.
  19. TYPO3com commented on patch set 22 04/17/20, 14:13 Completed build in 1h 21m 48s on Fri, 17 Apr, 02:13 PM Test Summary: 73573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2722

  20. TYPO3com commented on patch set 22 04/17/20, 14:14 Completed build in 12m 32s on Fri, 17 Apr, 02:14 PM Test Summary: 72296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2730

  21. Markus Klein voted on patch set 23 CR +1 04/17/20, 14:22

  22. TYPO3com voted on patch set 23 V +1 04/17/20, 14:32 Completed build in 20m 20s on Fri, 17 Apr, 02:32 PM Test Summary: 73579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2733

  23. Georg Ringer voted on patch set 23 V +1 CR +1 04/17/20, 18:47

  24. Benni Mack voted on patch set 23 V +2 CR +2 04/17/20, 22:41

  25. Benni Mack merged patch set 24 04/17/20, 22:41