Review main Merged

63888[FEATURE] Add filter to "New content element" wizard

Benni Mack CR +2 V +2 Normal +223 −12 updated 03/26/20, 08:19

Commit message

This patch introduces a filter in the "New Content Element" wizard which
enables a backend user to search for their wanted content element
respecting the CE name and description.

If a query leads to the situation that a tab has no results, that very
tab becomes unavailable to the user. If the current active tab has no
results, the next available tab is made active.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1929

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 03/24/20, 11:02

  2. TYPO3com voted on patch set 1 V -1 03/24/20, 11:13 Completed build in 10m 45s on Tue, 24 Mar, 11:13 AM Test Summary: 72560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1661

  3. Andreas Kienast uploaded patch set 2 03/24/20, 11:30

  4. TYPO3com voted on patch set 2 V +1 03/24/20, 11:41 Completed build in 10m 58s on Tue, 24 Mar, 11:41 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1662

  1. Andreas Kienast commented on patch set 2 CR -1 03/24/20, 15:02

    on it
  2. Andreas Kienast uploaded patch set 3 03/24/20, 17:55

  3. TYPO3com voted on patch set 3 V +1 03/24/20, 18:06 Completed build in 10m 53s on Tue, 24 Mar, 06:06 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1676

  4. Andreas Kienast uploaded patch set 4 03/25/20, 07:47

  5. TYPO3com voted on patch set 4 V +1 03/25/20, 08:00 Completed build in 13m 15s on Wed, 25 Mar, 08:00 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1693

  6. Andreas Kienast uploaded patch set 5 03/25/20, 08:02

  7. TYPO3com voted on patch set 5 V -1 03/25/20, 08:14 Completed build in 11m 27s on Wed, 25 Mar, 08:14 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1694

  8. Andreas Kienast uploaded patch set 6 03/25/20, 19:54

  9. TYPO3com voted on patch set 6 V -1 03/25/20, 19:54 Completed build in 09s on Wed, 25 Mar, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1724

  10. Andreas Kienast uploaded patch set 7 03/25/20, 19:55

  11. TYPO3com voted on patch set 7 V +1 03/25/20, 20:07 Completed build in 12m 07s on Wed, 25 Mar, 08:07 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1725

  12. Andreas Kienast uploaded patch set 8 03/25/20, 20:19

  13. TYPO3com voted on patch set 8 V +1 03/25/20, 20:33 Completed build in 14m 05s on Wed, 25 Mar, 08:33 PM Test Summary: 73015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1726

  14. Benni Mack commented on patch set 8 03/25/20, 21:03

    will decide if we mark it as a feature (due to the deprecation of the switchable controller actions)
  15. Wouter Wolters commented on patch set 8 03/25/20, 22:22

    Main.html:51

    shouldn't this text be translated?

    Main.html:52 Unresolved

    same here for placeholder
  16. Georg Ringer commented on patch set 8 03/25/20, 22:42

    Please convert to a feature. It is ok
  17. Andreas Kienast commented on patch set 8 CR -1 03/26/20, 05:48

    on it

    Main.html:51 Reply Unresolved

    Good catch, thanks
  18. Andreas Kienast uploaded patch set 9 03/26/20, 06:12

  19. TYPO3com voted on patch set 9 V -1 03/26/20, 06:34 Completed build in 21m 22s on Thu, 26 Mar, 06:34 AM Test Summary: 6 of 71304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1733

  20. TYPO3com voted on patch set 9 V +1 03/26/20, 06:44 Completed build in 53m 20s on Thu, 26 Mar, 06:44 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1733

  21. Susi Moog voted on patch set 9 V +1 03/26/20, 06:56

  22. Georg Ringer commented on patch set 9 V +1 CR +1 03/26/20, 08:07

    should we switch that modal to size large?
  23. Andreas Kienast commented on patch set 9 03/26/20, 08:13

    > Patch Set 9: Verified+1 Code-Review+1 > > should we switch that modal to size large? I'd say we should check how much the situation escalates and patch that afterwards.
  24. Frank Nägler voted on patch set 9 V +2 CR +2 03/26/20, 08:19

  25. Frank Nägler merged patch set 10 03/26/20, 08:19