63889[FEATURE] Add grouping and sorting for TCA select items
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 2
Files 13
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+10 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php6+144 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+163 −25
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php1+64 −1
- typo3/sysext/core/Configuration/TCA/pages.php+30 −11
- typo3/sysext/core/Documentation/Changelog/master/Feature-91008-ItemGroupingForTCASelectItems.rst9new+150 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-91008-ItemSortingForTCASelectItems.rst3new+58 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+117 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php1+7 −2
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+14 −42
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+2 −1
- typo3/sysext/frontend/Classes/Hooks/TableColumnHooks.phpdeleted+0 −47
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+73 −29
Review log 2540
Show 815 earlier messages
-
Benni Mack uploaded patch set 1 03/24/20, 11:31
-
TYPO3com voted on patch set 1 V +1 03/24/20, 11:47 Completed build in 14m 52s on Tue, 24 Mar, 11:47 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1663
-
Georg Ringer commented on patch set 1 03/24/20, 19:10
currently not working out for me, it always brings an empty optgroup for meExtensionUtility.php:155Unresolvedwhat about setting 'default' as default? -
Benni Mack uploaded patch set 2 04/12/20, 19:10
-
Benni Mack uploaded patch set 3 04/12/20, 19:21
-
TYPO3com voted on patch set 2 V -1 04/12/20, 19:23 Completed build in 13m 25s on Sun, 12 Apr, 07:23 PM Test Summary: 18 of 73881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2403
-
TYPO3com voted on patch set 3 V -1 04/12/20, 19:37 Completed build in 15m 05s on Sun, 12 Apr, 07:37 PM Test Summary: 18 of 73881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2405
-
Benni Mack uploaded patch set 4 04/12/20, 19:39
-
TYPO3com voted on patch set 4 V -1 04/12/20, 19:53 Completed build in 13m 14s on Sun, 12 Apr, 07:53 PM Test Summary: 18 of 73881 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2406
-
Benni Mack uploaded patch set 5 04/12/20, 21:58
-
Benni Mack uploaded patch set 6 04/12/20, 22:07
-
TYPO3com voted on patch set 6 V -1 04/12/20, 22:07 Completed build in 25s on Sun, 12 Apr, 10:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2413
-
Benni Mack uploaded patch set 7 04/12/20, 22:08
-
TYPO3com voted on patch set 5 V -1 04/12/20, 22:12 Completed build in 13m 16s on Sun, 12 Apr, 10:12 PM Test Summary: 36 of 73923 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2412
-
TYPO3com voted on patch set 7 V -1 04/12/20, 22:20 Completed build in 11m 59s on Sun, 12 Apr, 10:20 PM Test Summary: 36 of 73923 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2414
-
Benni Mack uploaded patch set 8 04/13/20, 08:00
-
TYPO3com voted on patch set 8 V -1 04/13/20, 08:12 Completed build in 12m 27s on Mon, 13 Apr, 08:12 AM Test Summary: 6 of 73941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2421
-
Benni Mack uploaded patch set 9 04/13/20, 08:38
-
TYPO3com voted on patch set 9 V +1 04/13/20, 08:52 Completed build in 13m 40s on Mon, 13 Apr, 08:52 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2423
-
Björn Jacob commented on patch set 9 04/13/20, 09:11
@Benni: will this awesome feature adress this issue as well? https://forge.typo3.org/issues/82352 IMHO your patch could finally solve the problem, right? -
Benni Mack updated the commit message in patch set 10 04/13/20, 09:12
-
Benni Mack commented on patch set 10 04/13/20, 09:12
Yes, Björn! Thanks for the hint! -
TYPO3com voted on patch set 10 V +1 04/13/20, 09:29 Completed build in 16m 40s on Mon, 13 Apr, 09:29 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2426
-
Björn Jacob commented on patch set 10 CR -1 04/13/20, 11:07
Benni asked me to do a review of the RST files. Here it is :) Love this feature and good to see a form issue solved.TcaSelectItems.php:189Unresolved"are"TcaSelectItems.php:194Unresolvedtbh I don't get this. Do we need this information? Can we add it to an own sentence?TcaSelectItems.php:202Unresolved"The"TcaSelectItems.php:228Unresolved"Put"TcaSelectItems.php:238Unresolved"Put"TcaSelectItems.php:255Unresolved"Let's"ExtensionManagementUtility.php:1239Unresolved"an"Feature-91008-ItemGroupingForTCASelectItems.rst:14Unresolved"which were then moved"Feature-91008-ItemGroupingForTCASelectItems.rst:16Unresolved"plugins" - I would remove the "and" and use lowercase for "plugins"Feature-91008-ItemGroupingForTCASelectItems.rst:17Unresolved"content types"Feature-91008-ItemGroupingForTCASelectItems.rst:19UnresolvedI would prefer an additional sentence: "Custom groups can be added via API or by defining TCA." I've changed the order to reflect the order of the examples below."Feature-91008-ItemGroupingForTCASelectItems.rst:24Unresolved"The following two examples illustrate adding a new group to a field of type `select`."Feature-91008-ItemGroupingForTCASelectItems.rst:54UnresolvedCan you come up with an example when using the TCA definition is better? Or does the following paragraph is about this topic?Feature-91008-ItemGroupingForTCASelectItems.rst:68UnresolvedShould it be "content type" instead? Is it a technical term we normally spell that way?Feature-91008-ItemGroupingForTCASelectItems.rst:125UnresolvedThere should be a newline above.Feature-91008-ItemGroupingForTCASelectItems.rst:129UnresolvedWe do have different spellings when it comes to capitalization (within the first paragraph there is "page types"). What should we prefer?Feature-91008-ItemSortingForTCASelectItems.rst:19UnresolvedI don't get this. Does not feel right.Feature-91008-ItemSortingForTCASelectItems.rst:45Unresolved"sorting is working on a" -
Georg Ringer voted on patch set 10 V +1 CR +1 04/13/20, 17:03
-
Benni Mack uploaded patch set 11 04/14/20, 07:07
-
TYPO3com voted on patch set 11 V +1 04/14/20, 07:19 Completed build in 11m 51s on Tue, 14 Apr, 07:19 AM Test Summary: 73505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2475
-
Björn Jacob commented on patch set 11 04/14/20, 07:27
Awesome Benni. Thx for taking care. Found one minor thing.Feature-91008-ItemSortingForTCASelectItems.rst:19UnresolvedThis "but" does not make much sense :) -
Benni Mack commented on patch set 12 04/14/20, 07:51
Published edit on patch set 11. -
TYPO3com voted on patch set 12 V -1 04/14/20, 08:23 Completed build in 31m 23s on Tue, 14 Apr, 08:23 AM Test Summary: 73505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2477
-
TYPO3com voted on patch set 12 V +1 04/14/20, 08:45 Completed build in 1h 25m 23s on Tue, 14 Apr, 08:45 AM Test Summary: 73505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2477
-
Benni Mack uploaded patch set 13 04/14/20, 12:11
-
TYPO3com voted on patch set 13 V +1 04/14/20, 12:29 Completed build in 16m 59s on Tue, 14 Apr, 12:28 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2495
-
Georg Ringer voted on patch set 13 V +1 CR +1 04/14/20, 12:56
-
Benni Mack uploaded patch set 14 04/15/20, 07:53
-
TYPO3com voted on patch set 14 V +1 04/15/20, 08:17 Completed build in 18m 23s on Wed, 15 Apr, 08:17 AM Test Summary: 73568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2551
-
Georg Ringer voted on patch set 14 V +1 CR +1 04/15/20, 09:53
-
Alexander Schnitzler commented on patch set 14 V +1 CR +1 04/15/20, 14:31
Tested with ext news and works great. -
Benni Mack voted on patch set 14 V +2 CR +2 04/15/20, 15:44
-
Benni Mack merged patch set 15 04/15/20, 15:44