Review 9.5 Merged

63901[BUGFIX] Allow all child nodes in ActionMenuItemGroupViewHelper

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 04/21/20, 10:21

Commit message

While it was with good intentions, restricting the allowed child nodes
of the view helper restricts developers / integrators too much in their
usage as valid cases of using loops or conditions do not work anymore.
These restrictions have been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Daniel Goerz commented on patch set 1 03/26/20, 15:40

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/26/20, 15:53 Completed build in 12m 55s on Thu, 26 Mar, 03:53 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-353

  3. Susi Moog voted on patch set 1 V +1 CR +1 03/27/20, 16:31

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/21/20, 10:21

  5. Benni Mack merged patch set 2 04/21/20, 10:21