Review 9.5 Merged

63908[BUGFIX] Do not render a-tag if URL is empty in link.action VH

Frank Nägler CR +2 V +2 Easy +3 −0 updated 03/27/20, 15:09

Commit message

If the URL cannot be calculated by the UriBuilder an empty URL
is returned. In this case no a-tag is rendered to avoid links
with an empty href-attribute.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Frank Nägler commented on patch set 1 03/27/20, 14:47

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
  2. TYPO3com voted on patch set 1 V -1 03/27/20, 14:47 Completed build in 22s on Fri, 27 Mar, 02:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-364

  3. Frank Nägler uploaded patch set 2 03/27/20, 14:51

  4. Frank Nägler commented on patch set 2 03/27/20, 14:51

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 03/27/20, 15:08 Completed build in 17m 00s on Fri, 27 Mar, 03:08 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-365

  6. Frank Nägler voted on patch set 2 V +2 CR +2 03/27/20, 15:09

  7. Frank Nägler merged patch set 3 03/27/20, 15:09