Review 9.5 Merged

63911[BUGFIX] Allow multiline comments in SqlReader

Daniel Goerz CR +2 V +2 Easy +49 −1 updated 06/05/20, 14:28

Commit message

When using c-style multiline comments in the ext_tables.sql of an
extension, the SchemaMigrator would then ignore the subsequent
"CREATE TABLE" statement, because the SqlReader also read the multiline
comments into the statement array.
This patch fixes this behaviour.
Now the following comments are possible inside ext_tables.sql:

/*
 Some comment text
 more text
*/

/* Same line c-style comment */

/* More multiline
 comments */

CREATE TABLE table1 (
    header varchar(255) DEFAULT '' NOT NULL,
    bodytext text
);

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Daniel Goerz commented on patch set 1 03/27/20, 15:52

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/27/20, 16:17 Completed build in 13m 25s on Fri, 27 Mar, 04:17 PM Test Summary: 30 of 74639 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-369

  3. Daniel Goerz commented on patch set 2 03/27/20, 16:26

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 03/27/20, 16:39 Completed build in 12m 43s on Fri, 27 Mar, 04:39 PM Test Summary: 74487 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-371

  5. Daniel Goerz voted on patch set 2 V +2 CR +2 06/05/20, 14:28

  6. Daniel Goerz merged patch set 3 06/05/20, 14:28