Review main Merged

63913[BUGFIX] Sort upgrade documentation by filename

Josef Glatz CR +2 V +2 Easy +1 −1 updated 03/25/20, 08:58

Commit message

Restore sorting of documentation files based on their filename
like it was available up to TYPO3 version 8.7.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Josef Glatz uploaded patch set 1 03/25/20, 07:00

  2. Susi Moog commented on patch set 1 03/25/20, 07:08

    DocumentationFile.php:266 Unresolved

    if this is just about keeping same types of files together, it would probably be easier to just modify the finder to sort by name wouldn't it?
  3. Josef Glatz commented on patch set 1 CR -1 03/25/20, 07:09

    > Patch Set 1: > > (1 comment) Georg and I are investigate that actually
  4. TYPO3com voted on patch set 1 V +1 03/25/20, 07:18 Completed build in 18m 10s on Wed, 25 Mar, 07:18 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1690

  5. Josef Glatz uploaded patch set 2 03/25/20, 07:27

  6. Josef Glatz commented on patch set 2 03/25/20, 07:30

    Of course it would be nice to order the documentation files not only by filename. But for now the state as it was up to 8.7 is restored again! Helps a lot if you upgrade your instance and see "more" important stuff at first. As Georg mentioned in private chat: my try to add custom sorting based on type in patch1 needs to be done with something like https://symfony.com/doc/current/components/finder.html#sorting-results
  7. TYPO3com voted on patch set 2 V -1 03/25/20, 07:38 Completed build in 10m 41s on Wed, 25 Mar, 07:38 AM Test Summary: 73016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1691

  8. TYPO3com voted on patch set 2 V +1 03/25/20, 08:07 Completed build in 50m 36s on Wed, 25 Mar, 08:07 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1691

  9. Georg Ringer voted on patch set 2 V +1 CR +1 03/25/20, 08:24

  10. Josef Glatz updated the commit message in patch set 3 03/25/20, 08:24

  11. Georg Ringer voted on patch set 3 V +1 CR +1 03/25/20, 08:25

  12. TYPO3com voted on patch set 3 V +1 03/25/20, 08:35 Completed build in 10m 56s on Wed, 25 Mar, 08:35 AM Test Summary: 73016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1696

  13. Susi Moog voted on patch set 3 V +2 CR +2 03/25/20, 08:58

  14. Susi Moog merged patch set 4 03/25/20, 08:58