Review main Merged

63914[BUGFIX] Avoid error in imageLinkWrap for non-existing files

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/27/20, 11:33

Commit message

ImageLinkWrap may not get a valid file object but will still try to
access methods on it which will fail. This patch implements a null check
resulting in simply not linking the image if the given file resource is
invalid.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Wouter Wolters +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Susi Moog uploaded patch set 1 03/25/20, 10:08

  2. Georg Ringer voted on patch set 1 CR +1 03/25/20, 10:19

  3. TYPO3com voted on patch set 1 V -1 03/25/20, 10:19 Completed build in 10m 52s on Wed, 25 Mar, 10:19 AM Test Summary: 72724 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1698

  4. TYPO3com voted on patch set 1 V +1 03/25/20, 11:26 Completed build in 1h 28m 34s on Wed, 25 Mar, 11:26 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1698

  5. Guido Schmechel voted on patch set 1 CR +1 03/25/20, 19:44

  6. Daniel Goerz voted on patch set 1 CR +1 03/25/20, 19:51

  7. Andreas Kienast voted on patch set 1 CR +1 03/25/20, 20:14

  8. Wouter Wolters voted on patch set 1 CR +1 03/25/20, 22:23

  9. Frank Nägler voted on patch set 1 V +1 CR +1 03/27/20, 11:33

  10. Andreas Kienast voted on patch set 1 V +1 CR 0 03/27/20, 11:33

  11. Frank Nägler voted on patch set 1 V +2 CR +2 03/27/20, 11:33

  12. Frank Nägler merged patch set 2 03/27/20, 11:33