Review main Merged

63915[TASK] Use button group for create/filter in page tree

Susi Moog CR +2 V +2 Easy +4 −6 updated 03/26/20, 14:20

Commit message

The buttons on top of the page tree behave like a button group and
should be styled as such.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1222

  1. Susi Moog uploaded patch set 1 03/25/20, 11:21

  2. TYPO3com voted on patch set 1 V -1 03/25/20, 11:32 Completed build in 10m 44s on Wed, 25 Mar, 11:32 AM Test Summary: 10 of 73501 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1702

  3. Benni Mack commented on patch set 1 03/25/20, 11:35

    wouldn't add this to 9.5
  4. Susi Moog updated the commit message in patch set 2 03/25/20, 12:15

  5. TYPO3com voted on patch set 2 V -1 03/25/20, 12:26 Completed build in 10m 56s on Wed, 25 Mar, 12:26 PM Test Summary: 72724 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1705

  6. TYPO3com voted on patch set 2 V +1 03/25/20, 12:43 Completed build in 38m 25s on Wed, 25 Mar, 12:43 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1705

  7. Daniel Haupt commented on patch set 2 03/25/20, 12:57

    Unresolved

    nit: "filter"
  8. Daniel Haupt wrote 03/25/20, 12:57

    Removed reviewer Daniel Haupt.
  9. Susi Moog updated the commit message in patch set 3 03/25/20, 13:03

  10. TYPO3com voted on patch set 3 V -1 03/25/20, 13:14 Completed build in 11m 11s on Wed, 25 Mar, 01:14 PM Test Summary: 10 of 73503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1707

  11. Georg Ringer updated the commit message in patch set 4 03/25/20, 13:34

  12. TYPO3com voted on patch set 4 V -1 03/25/20, 13:45 Completed build in 11m 20s on Wed, 25 Mar, 01:45 PM Test Summary: 12 of 73502 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1709

  13. Susi Moog updated the commit message in patch set 5 03/25/20, 14:32

  14. TYPO3com commented on patch set 4 03/25/20, 14:37 Completed build in 1h 14m 57s on Wed, 25 Mar, 02:37 PM Test Summary: 22 of 73502 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1709

  15. TYPO3com voted on patch set 5 V -1 03/25/20, 14:44 Completed build in 11m 36s on Wed, 25 Mar, 02:44 PM Test Summary: 31 of 73504 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1713

  16. TYPO3com commented on patch set 5 03/25/20, 15:08 Completed build in 47m 18s on Wed, 25 Mar, 03:08 PM Test Summary: 11 of 73504 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1713

  17. TYPO3com commented on patch set 5 03/25/20, 15:22 Completed build in 10m 36s on Wed, 25 Mar, 03:22 PM Test Summary: 73016 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1714

  18. TYPO3com voted on patch set 5 V +1 03/25/20, 15:36 Completed build in 35m 00s on Wed, 25 Mar, 03:36 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1714

  19. Daniel Goerz voted on patch set 5 V +1 CR +1 03/25/20, 19:46

  20. Andreas Kienast voted on patch set 5 V +2 CR +2 03/25/20, 20:15

  21. Andreas Kienast merged patch set 6 03/25/20, 20:16

  22. Susi Moog wrote 03/26/20, 14:20

    Created a revert of this change as Icfde2974fd79c436ecbb25f515c1a97662d6b61d