Review main Abandoned

63916[WIP][BUGFIX] Rework cObj->getTreeList()

Benni Mack CR 0 V 0 Normal +246 −3 updated 04/20/20, 20:00

Commit message

The method for fetching the subpages of a page ID built in cObj->getTreeList()
has various drawbacks:
- multi-functional values (negative IDs)
- inflexible enableFields selection

In addition it has a faulty behavior when dealing with workspaces and
when a backend user is previewing hidden content.

In general, this method rather belongs to PageRepository, which can
then be used in other places as well.

ToDo
- What we need is functional tests to show the behavior based on various
settings which could work.
- In this setting, we could/should also incorporate the caching framework
- Also, deprecating getTreeList() would make a lot of sense

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 35

  1. Benni Mack uploaded patch set 1 03/25/20, 11:44

  2. TYPO3com voted on patch set 1 V +1 03/25/20, 11:56 Completed build in 11m 21s on Wed, 25 Mar, 11:56 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1703

  3. Benni Mack updated the commit message in patch set 2 03/25/20, 12:27

  4. TYPO3com voted on patch set 2 V -1 03/25/20, 12:37 Completed build in 10m 32s on Wed, 25 Mar, 12:37 PM Test Summary: 72708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1706

  5. Benni Mack abandoned the change 04/20/20, 20:00