63918[TASK] Streamline BackendLayout API class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Frank Nägler +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php2+4 −4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+4 −21
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+3 −4
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+31 −69
- typo3/sysext/backend/Classes/View/BackendLayoutView.php4+98 −24
Review log 1424
-
Benni Mack uploaded patch set 1 03/25/20, 17:01
-
TYPO3com voted on patch set 1 V -1 03/25/20, 17:11 Completed build in 10m 36s on Wed, 25 Mar, 05:11 PM Test Summary: 58 of 73047 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1716
-
Benni Mack uploaded patch set 2 03/26/20, 11:29
-
TYPO3com voted on patch set 2 V -1 03/26/20, 11:40 Completed build in 10m 59s on Thu, 26 Mar, 11:40 AM Test Summary: 6 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757
-
TYPO3com commented on patch set 2 03/26/20, 11:45 Completed build in 27m 04s on Thu, 26 Mar, 11:45 AM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757
-
TYPO3com commented on patch set 2 03/26/20, 11:48 Completed build in 46m 17s on Thu, 26 Mar, 11:48 AM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757
-
Georg Ringer commented on patch set 2 03/26/20, 11:49
-
Benni Mack commented on patch set 2 03/26/20, 11:57
LocalizationController.php:266Reply UnresolvedPlease check the context - this is already a controller which returns the columns directly as JSON. LanguageService->sL() works like this - if the string starts with LLL: it gets transformed, otherwise returned.. -
Benni Mack uploaded patch set 3 03/26/20, 11:57
-
Benni Mack uploaded patch set 4 03/26/20, 12:02
-
TYPO3com voted on patch set 3 V -1 03/26/20, 12:09 Completed build in 11m 56s on Thu, 26 Mar, 12:09 PM Test Summary: 16 of 63165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760
-
TYPO3com voted on patch set 4 V -1 03/26/20, 12:20 Completed build in 14m 18s on Thu, 26 Mar, 12:20 PM Test Summary: 5 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1762
-
TYPO3com commented on patch set 3 03/26/20, 12:27 Completed build in 42m 00s on Thu, 26 Mar, 12:27 PM Test Summary: 10 of 73497 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760
-
TYPO3com commented on patch set 3 03/26/20, 12:36 Completed build in 1h 20m 37s on Thu, 26 Mar, 12:36 PM Test Summary: 6 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760
-
TYPO3com commented on patch set 3 03/26/20, 12:49 Completed build in 2h 12m 12s on Thu, 26 Mar, 12:49 PM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760
-
TYPO3com voted on patch set 4 V +1 03/26/20, 12:58 Completed build in 1h 06m 26s on Thu, 26 Mar, 12:58 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1762
-
Georg Ringer voted on patch set 4 V +1 CR +1 03/26/20, 13:20
-
Frank Nägler voted on patch set 4 V +1 CR +1 03/26/20, 15:22
-
Benni Mack voted on patch set 4 V +2 CR +2 03/26/20, 15:48
-
Benni Mack merged patch set 5 03/26/20, 15:48
-
Oliver Hader commented on patch set 5 03/26/20, 16:03
BackendLayoutView.php:380UnresolvedI'm not sure whether this could be part of the BackendLayout in terms of "BackendLayout can parse and assign their structure"... otherwise it would be kind of a factory. The only local dependency is resolving column names probably having a LLL local-lang prefix... -
Claus Due commented on patch set 5 03/28/20, 12:48
BackendLayoutView.php:335This has changed the signature of a public API method, and therefore makes the change breaking. This should probably be undone (in a followup patch). -
Oliver Hader commented on patch set 5 03/28/20, 13:02
BackendLayoutView.php:335ReplyBackendLayoutView is @internal, isn't it?! -
Claus Due commented on patch set 5 03/28/20, 13:07
BackendLayoutView.php:335Reply UnresolvedOh right, it is. Even so I'd still like to request that this gets undone as it has broken the XCLASS I am forced to use in Flux.
LocalizationController.php:266