Review main Merged

63918[TASK] Streamline BackendLayout API class

Benni Mack CR +2 V +2 Hard +140 −122 updated 03/28/20, 13:07

Commit message

This change moves the ConditionMatching back to the BackendLayoutView.

The main goal is to make BackendLayout more of an entity class again,
whereas BackendLayoutView should be the process to build the BackendLayout
objects, and configuration and return them, and act more as a
BackendLayoutResolver - this could / should be renamed in the future.

This change thus reactivates runtime-caching for fetching
a backend layout configuration again.

In addition, the new method "getBackendLayoutForPage()" now
actually returns a "ready-to-use" Backend Layout instance,
which could also used for the Nested Content Grid in the future.

The previous "configurationArray" is now defined as "stucture".

A short-hand function "getUsedColumns()" is added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1424

  1. Benni Mack uploaded patch set 1 03/25/20, 17:01

  2. TYPO3com voted on patch set 1 V -1 03/25/20, 17:11 Completed build in 10m 36s on Wed, 25 Mar, 05:11 PM Test Summary: 58 of 73047 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1716

  3. Benni Mack uploaded patch set 2 03/26/20, 11:29

  4. TYPO3com voted on patch set 2 V -1 03/26/20, 11:40 Completed build in 10m 59s on Thu, 26 Mar, 11:40 AM Test Summary: 6 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757

  5. TYPO3com commented on patch set 2 03/26/20, 11:45 Completed build in 27m 04s on Thu, 26 Mar, 11:45 AM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757

  6. TYPO3com commented on patch set 2 03/26/20, 11:48 Completed build in 46m 17s on Thu, 26 Mar, 11:48 AM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1757

  7. Georg Ringer commented on patch set 2 03/26/20, 11:49

    LocalizationController.php:266

    should there be a fallback to $columnLabel if there is no translation/no LLL string? or can we transform the LLL at a later point in the view?
  8. Benni Mack commented on patch set 2 03/26/20, 11:57

    LocalizationController.php:266 Reply Unresolved

    Please check the context - this is already a controller which returns the columns directly as JSON. LanguageService->sL() works like this - if the string starts with LLL: it gets transformed, otherwise returned..
  9. Benni Mack uploaded patch set 3 03/26/20, 11:57

  10. Benni Mack uploaded patch set 4 03/26/20, 12:02

  11. TYPO3com voted on patch set 3 V -1 03/26/20, 12:09 Completed build in 11m 56s on Thu, 26 Mar, 12:09 PM Test Summary: 16 of 63165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760

  12. TYPO3com voted on patch set 4 V -1 03/26/20, 12:20 Completed build in 14m 18s on Thu, 26 Mar, 12:20 PM Test Summary: 5 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1762

  13. TYPO3com commented on patch set 3 03/26/20, 12:27 Completed build in 42m 00s on Thu, 26 Mar, 12:27 PM Test Summary: 10 of 73497 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760

  14. TYPO3com commented on patch set 3 03/26/20, 12:36 Completed build in 1h 20m 37s on Thu, 26 Mar, 12:36 PM Test Summary: 6 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760

  15. TYPO3com commented on patch set 3 03/26/20, 12:49 Completed build in 2h 12m 12s on Thu, 26 Mar, 12:49 PM Test Summary: 2 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1760

  16. TYPO3com voted on patch set 4 V +1 03/26/20, 12:58 Completed build in 1h 06m 26s on Thu, 26 Mar, 12:58 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1762

  17. Georg Ringer voted on patch set 4 V +1 CR +1 03/26/20, 13:20

  18. Frank Nägler voted on patch set 4 V +1 CR +1 03/26/20, 15:22

  19. Benni Mack voted on patch set 4 V +2 CR +2 03/26/20, 15:48

  20. Benni Mack merged patch set 5 03/26/20, 15:48

  21. Oliver Hader commented on patch set 5 03/26/20, 16:03

    BackendLayoutView.php:380 Unresolved

    I'm not sure whether this could be part of the BackendLayout in terms of "BackendLayout can parse and assign their structure"... otherwise it would be kind of a factory. The only local dependency is resolving column names probably having a LLL local-lang prefix...
  22. Claus Due commented on patch set 5 03/28/20, 12:48

    BackendLayoutView.php:335

    This has changed the signature of a public API method, and therefore makes the change breaking. This should probably be undone (in a followup patch).
  23. Oliver Hader commented on patch set 5 03/28/20, 13:02

    BackendLayoutView.php:335 Reply

    BackendLayoutView is @internal, isn't it?!
  24. Claus Due commented on patch set 5 03/28/20, 13:07

    BackendLayoutView.php:335 Reply Unresolved

    Oh right, it is. Even so I'd still like to request that this gets undone as it has broken the XCLASS I am forced to use in Flux.