Review main Merged

63919[BUGFIX] Reset number of results in QueryResult after offset changes

Susi Moog CR +2 V +2 Easy +20 −0 updated 03/26/20, 08:08

Commit message

Using offsetSet or unset allows manipulating the QueryResult manually.
As the result of `count` is cached, offset changes need to reset that
cache to accurately return the correct offset.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Susi Moog uploaded patch set 1 03/25/20, 17:13

  2. TYPO3com voted on patch set 1 V -1 03/25/20, 17:25 Completed build in 11m 12s on Wed, 25 Mar, 05:25 PM Test Summary: 72715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1717

  3. TYPO3com voted on patch set 1 V +1 03/25/20, 17:33 Completed build in 30m 25s on Wed, 25 Mar, 05:33 PM Test Summary: 73023 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1717

  4. Wouter Wolters voted on patch set 1 CR +1 03/25/20, 22:29

  5. Andreas Kienast commented on patch set 1 V +1 CR +1 03/26/20, 07:23

    Verified by reverting the change in QueryResult.php and executing the tests again
  6. Georg Ringer voted on patch set 1 V +2 CR +2 03/26/20, 08:08

  7. Georg Ringer merged patch set 2 03/26/20, 08:08