Review main Merged

63920[BUGFIX] Fix target path handling of UploadedFile

Susi Moog CR +2 V +2 Easy +1 −2 updated 03/26/20, 08:29

Commit message

The PSR-7 interface states that moveTo shall use `$target` as full
`$target` path (including the file name) for uploaded files. In addition,
the current implementation was inconsistent when handling streams vs.
files. The implementation has been adjusted according to the standard.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Susi Moog uploaded patch set 1 03/25/20, 17:30

  2. TYPO3com voted on patch set 1 V -1 03/25/20, 17:30 Completed build in 24s on Wed, 25 Mar, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1718

  3. Susi Moog uploaded patch set 2 03/25/20, 17:33

  4. TYPO3com voted on patch set 2 V +1 03/25/20, 17:44 Completed build in 11m 00s on Wed, 25 Mar, 05:44 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1719

  5. Wouter Wolters voted on patch set 2 CR +1 03/25/20, 22:28

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 03/26/20, 08:27

  7. Frank Nägler voted on patch set 2 V +2 CR +2 03/26/20, 08:28

  8. Frank Nägler merged patch set 3 03/26/20, 08:29