Review main Merged

63921[BUGFIX] Ensure to override JSwindow custom parameters

Benni Mack CR +2 V +2 Easy +23 −3 updated 03/26/20, 17:06

Commit message

Currently "typolink.JSwindow_params" allows to set custom parameters
when opening a link within a JS-based popup. When linking an image,
the custom parameters have been added as well.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 03/25/20, 19:27

  2. Susi Moog voted on patch set 1 CR +1 03/25/20, 19:28

  3. TYPO3com voted on patch set 1 V +1 03/25/20, 19:38 Completed build in 11m 08s on Wed, 25 Mar, 07:38 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1722

  4. Wouter Wolters voted on patch set 1 CR +1 03/25/20, 22:27

  5. Susi Moog uploaded patch set 2 03/26/20, 06:13

  6. Susi Moog commented on patch set 2 V +1 CR +1 03/26/20, 06:13

    (added missing closing bracket)
  7. TYPO3com voted on patch set 2 V +1 03/26/20, 06:41 Completed build in 27m 47s on Thu, 26 Mar, 06:41 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1734

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 03/26/20, 17:06

  9. Daniel Goerz merged patch set 3 03/26/20, 17:06