Review main Merged

63922[BUGFIX] Use target attribute for JSwindow_params in typolink

Benni Mack CR +2 V +2 Normal +53 −6 updated 03/30/20, 07:35

Commit message

When using "typolink.JSwindow_params" the target set by typolink.target
or the encoded "typolink parameter", but always falls back to "FEopenLink".

If the property "target" is now set, the JSwindow_params "target" value
is now also taken into account.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Benni Mack uploaded patch set 1 03/25/20, 19:48

  2. TYPO3com voted on patch set 1 V +1 03/25/20, 20:00 Completed build in 11m 14s on Wed, 25 Mar, 08:00 PM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1723

  3. Andreas Kienast commented on patch set 1 03/25/20, 20:04

    ContentObjectRenderer.php:5108 Unresolved

    This null coalesce doesn't make much sense to me. In line 5100 $tagAttributes['target'] gets the value of $target if it's not empty. OTOH I don't understand why line 5101 also checks for XHTML.
  4. Benni Mack commented on patch set 1 CR -1 03/26/20, 17:29

    Let's add tests and also change one more place in HMENU as well
  5. Benni Mack uploaded patch set 2 03/27/20, 17:01

  6. TYPO3com voted on patch set 2 V -1 03/27/20, 17:01 Completed build in 30s on Fri, 27 Mar, 05:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1868

  7. Benni Mack uploaded patch set 3 03/27/20, 17:03

  8. Benni Mack uploaded patch set 4 03/27/20, 17:03

  9. TYPO3com voted on patch set 3 V -1 03/27/20, 17:03 Completed build in 30s on Fri, 27 Mar, 05:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1869

  10. TYPO3com voted on patch set 4 V +1 03/27/20, 17:14 Completed build in 11m 05s on Fri, 27 Mar, 05:14 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1870

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 03/28/20, 07:57

  12. Georg Ringer voted on patch set 4 V +2 CR +2 03/30/20, 07:35

  13. Georg Ringer merged patch set 5 03/30/20, 07:35