Review main Merged

63926[BUGFIX] Missing space before GeneralUtility::implodeAttributes

Eric Chavaillaz CR +2 V +2 Easy +5 −5 updated 03/26/20, 08:42

Commit message

This patch fix missing space before calling GeneralUtility::implodeAttributes.
Without space, the rendered HTML is not valid.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 45

  1. Eric Chavaillaz uploaded patch set 1 03/26/20, 08:13

  2. Georg Ringer voted on patch set 1 V +1 CR +1 03/26/20, 08:21

  3. TYPO3com voted on patch set 1 V +1 03/26/20, 08:33 Completed build in 17m 12s on Thu, 26 Mar, 08:33 AM Test Summary: 73009 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1743

  4. Frank Nägler voted on patch set 1 V +2 CR +2 03/26/20, 08:42

  5. Frank Nägler merged patch set 2 03/26/20, 08:42