Review main Merged

63927[BUGFIX] Allow all child nodes in ActionMenuItemGroupViewHelper

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/26/20, 15:40

Commit message

While it was with good intentions, restricting the allowed child nodes
of the view helper restricts developers / integrators too much in their
usage as valid cases of using loops or conditions do not work anymore.
These restrictions have been removed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 611

  1. Susi Moog uploaded patch set 1 03/26/20, 08:42

  2. Frank Nägler voted on patch set 1 CR +1 03/26/20, 08:44

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/26/20, 08:48

  4. TYPO3com voted on patch set 1 V -1 03/26/20, 08:54 Completed build in 11m 17s on Thu, 26 Mar, 08:54 AM Test Summary: 73005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1746

  5. TYPO3com voted on patch set 1 V +1 03/26/20, 14:55 Completed build in 6h 24m 06s on Thu, 26 Mar, 02:55 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1746

  6. TYPO3com voted on patch set 1 V -1 03/26/20, 14:57 Completed build in 12m 15s on Thu, 26 Mar, 02:57 PM Test Summary: 11 of 62559 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1771

  7. TYPO3com commented on patch set 1 03/26/20, 15:09 Completed build in 37m 07s on Thu, 26 Mar, 03:09 PM Test Summary: 15 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1771

  8. Daniel Goerz voted on patch set 1 CR +1 03/26/20, 15:22

  9. TYPO3com voted on patch set 1 V +1 03/26/20, 15:38 Completed build in 1h 30m 43s on Thu, 26 Mar, 03:38 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1771

  10. Daniel Goerz voted on patch set 1 V +2 CR +2 03/26/20, 15:40

  11. Daniel Goerz merged patch set 2 03/26/20, 15:40