Review main Merged

63932[TASK] Update EnvironmentStatus OpcodeCache info

Susi Moog CR +2 V +2 Normal +25 −32 updated 03/27/20, 10:45

Commit message

The original implementation was meant to handle different variants of
opcaches. As of now, only the native PHP opcache is still supported.

This patch cleans up the settings and setup check and adds an
additional check whether clearing is possible or deactivated via
disable_functions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 917

  1. Susi Moog uploaded patch set 1 03/26/20, 11:56

  2. TYPO3com voted on patch set 1 V -1 03/26/20, 11:57 Completed build in 25s on Thu, 26 Mar, 11:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1759

  3. Susi Moog uploaded patch set 2 03/26/20, 12:00

  4. TYPO3com voted on patch set 2 V -1 03/26/20, 12:16 Completed build in 15m 33s on Thu, 26 Mar, 12:16 PM Test Summary: 19 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1761

  5. TYPO3com commented on patch set 2 03/26/20, 14:51 Completed build in 12m 16s on Thu, 26 Mar, 02:51 PM Test Summary: 4 of 73496 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1770

  6. TYPO3com commented on patch set 2 03/26/20, 15:00 Completed build in 33m 26s on Thu, 26 Mar, 03:00 PM Test Summary: 3 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1770

  7. TYPO3com commented on patch set 2 03/26/20, 17:02 Completed build in 46m 19s on Thu, 26 Mar, 05:02 PM Test Summary: 3 of 73495 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1770

  8. Susi Moog commented on patch set 3 03/26/20, 17:35

    Published edit on patch set 2.
  9. TYPO3com voted on patch set 3 V -1 03/26/20, 17:46 Completed build in 10m 59s on Thu, 26 Mar, 05:46 PM Test Summary: 3 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1783

  10. Susi Moog marked it work in progress 03/26/20, 18:15

  11. Susi Moog uploaded patch set 4 03/27/20, 04:57

  12. Susi Moog commented on patch set 4 03/27/20, 04:57

    This change is ready for review.
  13. TYPO3com voted on patch set 4 V -1 03/27/20, 05:12 Completed build in 15m 19s on Fri, 27 Mar, 05:12 AM Test Summary: 72721 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1807

  14. TYPO3com voted on patch set 4 V +1 03/27/20, 05:38 Completed build in 56m 56s on Fri, 27 Mar, 05:38 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1807

  15. Andreas Kienast voted on patch set 4 V +1 CR +1 03/27/20, 10:36

  16. Benni Mack voted on patch set 4 V +2 CR +2 03/27/20, 10:45

  17. Benni Mack merged patch set 5 03/27/20, 10:45