Review main Merged

63933[BUGFIX] Fix several methods of ExtensionService

Alexander Schnitzler CR +2 V +2 Normal +88 −15 updated 03/26/20, 16:25

Commit message

Due to a missing functional test and a legacy extension
configuration format in a unit test several issues with
methods in the ExtensionService class have not been
spotted.

Although the registration of plugins changed in that
manner that FQCN's are used instead of controller class
names, the internal handling in Extbase still relies on
controller names, which are internally named controller
aliases. The internal Extbase mechanics must still work
like before, passing the controller name around as this
is unique in the context of a plugin. Therefore it's not
necessary to expose or use the FQCN.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Tobias Schmidt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Tobias Schmidt +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 03/26/20, 12:09

  2. Alexander Schnitzler wrote 03/26/20, 12:10

    Topic set to extbase
  3. Alexander Schnitzler wrote 03/26/20, 12:10

    Hashtag added: regression
  4. TYPO3com voted on patch set 1 V -1 03/26/20, 12:24 Completed build in 14m 27s on Thu, 26 Mar, 12:24 PM Test Summary: 2 of 73500 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1763

  5. TYPO3com voted on patch set 1 V +1 03/26/20, 12:34 Completed build in 38m 17s on Thu, 26 Mar, 12:34 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1763

  6. Tobias Schmidt commented on patch set 1 V +1 CR +1 03/26/20, 15:22

    Looks good to me and works as expected in my specific use case as per description in #90822.
  7. Daniel Goerz voted on patch set 1 V +2 CR +2 03/26/20, 16:25

  8. Daniel Goerz merged patch set 2 03/26/20, 16:25