Review main Merged

63934[DOCS] Clarify what to avoid in checks on TYPO3_MODE

TYPO3com CR +2 V +2 Easy +3 −4 updated 03/27/20, 11:13

Commit message

With regards to
https://typo3.slack.com/archives/C025BQLFA/p1585231067123500 there seems
to be confusion in the paragraph about avoiding checks on TYPO3_MODE if
`defined('TYPO3_MODE') or die();` should be used or if that is forbidden
as well.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 510

  1. TYPO3com uploaded patch set 1 03/26/20, 14:33

  2. TYPO3com voted on patch set 1 V -1 03/26/20, 14:44 Completed build in 10m 52s on Thu, 26 Mar, 02:44 PM Test Summary: 13 of 73497 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1769

  3. Björn Jacob updated the commit message in patch set 2 03/26/20, 15:09

  4. Björn Jacob updated the commit message in patch set 3 03/26/20, 15:11

  5. TYPO3com voted on patch set 2 V +1 03/26/20, 15:21 Completed build in 11m 20s on Thu, 26 Mar, 03:21 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1773

  6. TYPO3com voted on patch set 3 V -1 03/26/20, 15:25 Completed build in 14m 24s on Thu, 26 Mar, 03:25 PM Test Summary: 8 of 73497 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1774

  7. TYPO3com voted on patch set 3 V +1 03/26/20, 18:26 Completed build in 3h 29m 38s on Thu, 26 Mar, 06:26 PM Test Summary: 73011 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1774

  8. Susi Moog voted on patch set 3 CR +1 03/27/20, 10:39

  9. Daniel Siepmann voted on patch set 3 V +2 CR +2 03/27/20, 11:13

  10. Daniel Siepmann merged patch set 4 03/27/20, 11:13