Review main Merged

63937[TASK] Bring back datetime related acceptance tests for FormEngine

Anja Leichsenring CR +2 V +2 Hard +138 −131 updated 04/12/20, 05:06

Commit message

The test have been disabled due to flakiness, let's give them
another chance to prove themselves valuable.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1729

Show 24 earlier messages
  1. Anja Leichsenring uploaded patch set 1 03/26/20, 19:56

  2. TYPO3com voted on patch set 1 V -1 03/26/20, 19:58 Completed build in 33s on Thu, 26 Mar, 07:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1795

  3. Anja Leichsenring uploaded patch set 2 03/26/20, 19:59

  4. TYPO3com voted on patch set 2 V -1 03/26/20, 20:13 Completed build in 14m 00s on Thu, 26 Mar, 08:13 PM Test Summary: 72411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1796

  1. TYPO3com voted on patch set 2 V +1 03/26/20, 20:25 Completed build in 40m 23s on Thu, 26 Mar, 08:25 PM Test Summary: 73018 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1796

  2. Oliver Klee updated the commit message in patch set 3 03/26/20, 20:32

  3. TYPO3com voted on patch set 3 V +1 03/26/20, 20:50 Completed build in 17m 08s on Thu, 26 Mar, 08:50 PM Test Summary: 73018 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1799

  4. Andreas Kienast voted on patch set 3 V +1 CR +1 03/29/20, 07:20

  5. Georg Ringer voted on patch set 3 CR +1 03/29/20, 07:23

  6. Benni Mack updated the commit message in patch set 4 04/06/20, 06:05

  7. TYPO3com voted on patch set 4 V -1 04/06/20, 06:18 Completed build in 12m 10s on Mon, 6 Apr, 06:18 AM Test Summary: 4 of 73003 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2212

  8. TYPO3com commented on patch set 4 04/06/20, 18:56 Completed build in 13h 02m 44s on Mon, 6 Apr, 06:56 PM Test Summary: 4 of 73854 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2212

  9. TYPO3com commented on patch set 4 04/06/20, 19:03 Completed build in 2h 00m 31s on Mon, 6 Apr, 07:03 PM Test Summary: 4 of 73854 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2212

  10. TYPO3com commented on patch set 4 04/06/20, 19:46 Completed build in 15m 37s on Mon, 6 Apr, 07:46 PM Test Summary: 4 of 73851 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2242

  11. Anja Leichsenring commented on patch set 4 04/06/20, 20:02

    broke it again, will fix asap.
  12. Anja Leichsenring uploaded patch set 5 04/07/20, 18:27

  13. TYPO3com voted on patch set 5 V +1 04/07/20, 18:44 Completed build in 14m 53s on Tue, 7 Apr, 06:44 PM Test Summary: 73367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2282

  14. Benni Mack commented on patch set 5 04/07/20, 20:40

    AbstractElementsBasicCest.php:134

    maybe we want to rename this method? :) "ensureTopOfFrameIsUsedAndClickTab()" - something like that? I don't know what you actually mean...
  15. Anja Leichsenring commented on patch set 6 04/08/20, 05:36

    Published edit on patch set 5.
  16. Anja Leichsenring commented on patch set 6 04/08/20, 05:37

    AbstractElementsBasicCest.php:134 Reply Unresolved

    this function changed its meaning so often during work, I was just out of words. Thanks for the suggestion.
  17. TYPO3com voted on patch set 6 V +1 04/08/20, 05:53 Completed build in 16m 52s on Wed, 8 Apr, 05:53 AM Test Summary: 73367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2288

  18. Andreas Kienast commented on patch set 6 CR -1 04/08/20, 06:05

    AbstractElementsBasicCest.php:154 Unresolved

    I sense an endless loop here.
  19. Anja Leichsenring uploaded patch set 7 04/08/20, 17:47

  20. TYPO3com voted on patch set 7 V -1 04/08/20, 17:59 Completed build in 11m 51s on Wed, 8 Apr, 05:59 PM Test Summary: 17 of 73851 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2318

  21. TYPO3com voted on patch set 7 V +1 04/08/20, 20:39 Completed build in 3h 04m 03s on Wed, 8 Apr, 08:39 PM Test Summary: 73367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2318

  22. Andreas Kienast voted on patch set 7 V +1 CR +1 04/09/20, 08:26

  23. Benni Mack voted on patch set 7 V +1 CR +1 04/11/20, 23:11

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 04/12/20, 05:06

  25. Andreas Kienast merged patch set 8 04/12/20, 05:06