63938[TASK] Clean up drawing configuration for Fluid-based page module
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php1+34 −59
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+3 −25
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+7 −1
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+1 −0
- typo3/sysext/backend/Classes/View/Drawing/DrawingConfiguration.php+3 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+29 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageLayout.html+1 −10
Review log 912
-
Benni Mack uploaded patch set 1 03/26/20, 20:27
-
TYPO3com voted on patch set 1 V +1 03/26/20, 20:43 Completed build in 15m 45s on Thu, 26 Mar, 08:43 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1798
-
Benni Mack updated the commit message in patch set 2 03/27/20, 13:06
-
Benni Mack updated the commit message in patch set 3 03/27/20, 13:09
-
TYPO3com voted on patch set 2 V +1 03/27/20, 13:28 Completed build in 18m 20s on Fri, 27 Mar, 01:28 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1836
-
TYPO3com voted on patch set 3 V +1 03/27/20, 13:37 Completed build in 23m 02s on Fri, 27 Mar, 01:37 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1838
-
Susi Moog voted on patch set 3 V +1 03/27/20, 14:11
-
Susi Moog voted on patch set 3 CR +1 03/27/20, 14:16
-
Georg Ringer voted on patch set 3 V +1 CR +1 03/27/20, 14:19
-
Daniel Goerz commented on patch set 3 CR +1 03/27/20, 14:36
-
Georg Ringer voted on patch set 3 V +2 CR +2 03/27/20, 14:44
-
Georg Ringer merged patch set 4 03/27/20, 14:44
PageLayoutController.php:628Unresolved