Review main Merged

63938[TASK] Clean up drawing configuration for Fluid-based page module

Benni Mack CR +2 V +2 Normal +83 −102 updated 03/27/20, 14:44

Commit message

PageLayoutView now builds a "Configuration" model for both variants
PageLayoutView is not set up via the DrawingConfiguration object,
which is now based on a factory method.

PageLayoutController now injects all RequireJS modules in one place,
and not in fluid anymore.

Minor bugs regarding "getLanguageColumns" are fixed.

The main "pageLayoutConfiguration" is now injected and used where it does not
differ from the backend module configuration.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 912

  1. Benni Mack uploaded patch set 1 03/26/20, 20:27

  2. TYPO3com voted on patch set 1 V +1 03/26/20, 20:43 Completed build in 15m 45s on Thu, 26 Mar, 08:43 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1798

  3. Benni Mack updated the commit message in patch set 2 03/27/20, 13:06

  4. Benni Mack updated the commit message in patch set 3 03/27/20, 13:09

  5. TYPO3com voted on patch set 2 V +1 03/27/20, 13:28 Completed build in 18m 20s on Fri, 27 Mar, 01:28 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1836

  6. TYPO3com voted on patch set 3 V +1 03/27/20, 13:37 Completed build in 23m 02s on Fri, 27 Mar, 01:37 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1838

  7. Susi Moog voted on patch set 3 V +1 03/27/20, 14:11

  8. Susi Moog voted on patch set 3 CR +1 03/27/20, 14:16

  9. Georg Ringer voted on patch set 3 V +1 CR +1 03/27/20, 14:19

  10. Daniel Goerz commented on patch set 3 CR +1 03/27/20, 14:36

    PageLayoutController.php:628 Unresolved

    int cast and ===
  11. Georg Ringer voted on patch set 3 V +2 CR +2 03/27/20, 14:44

  12. Georg Ringer merged patch set 4 03/27/20, 14:44