63940[BUGFIX] Output more helpful information in OrphanRecordsCommand
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Susi Moog +1
-
Verified V +2 Done
- Andreas Kienast +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Georg Ringer uploaded patch set 1 03/27/20, 00:03
-
Georg Ringer commented on patch set 1 03/27/20, 00:03
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/27/20, 00:15 Completed build in 12m 18s on Fri, 27 Mar, 12:15 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1803
-
Daniel Haupt voted on patch set 1 V +1 CR +1 03/27/20, 00:29
-
Daniel Haupt commented on patch set 1 03/27/20, 00:41
OrphanRecordsCommand.php:126UnresolvedSuggestion: I would prefer to output this once after leaving the foreach as the information does not seem to be that interesting after every table. This was also suggested by the issue author. I would be interested to hear your opinion on this! -
Georg Ringer commented on patch set 1 03/27/20, 01:15
I just wanted to keep the patch minimal as the code ifself is quite hard to understand. -
Susi Moog commented on patch set 1 03/27/20, 06:47
I would really suggest to adjust the output as Daniel already stated, as the output now is more confusing than before. ``` Find and delete records that have lost their connection with the page tree. =========================================================================== ! [NOTE] Found 4 orphan records in table "sys_file_reference" with following ids: 142, 143, 144, 145 ! [NOTE] Found 4 records in 1 database tables. ! [NOTE] Found 3 orphan records in table "tt_content" with following ids: 183, 184, 185 ! [NOTE] Found 3 records in 2 database tables. ``` It'a bit weird and contradictory now (note the 2 vs 1 table thing and the record count in combination). If you want to keep the patch minimal I'd suggest removing the second info completely (as you changed the verbosity level of the first, there is basically no benefit to the second) -
Susi Moog voted on patch set 1 V -1 03/27/20, 06:57
-
Georg Ringer uploaded patch set 2 03/27/20, 12:43
-
TYPO3com voted on patch set 2 V +1 03/27/20, 13:05 Completed build in 15m 39s on Fri, 27 Mar, 01:05 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1832
-
Susi Moog voted on patch set 2 V +1 CR +1 03/27/20, 13:12
-
Andreas Kienast voted on patch set 2 V +2 CR +2 03/27/20, 13:30
-
Andreas Kienast merged patch set 3 03/27/20, 13:30