Review main Merged

63942[BUGFIX] Catch invalid link formats in backend and frontend

Georg Ringer CR +2 V +2 Easy +13 −8 updated 03/27/20, 14:52

Commit message

Links with an invalid syntax or not supported type must not lead to
exceptions for an editor or users.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1418

  1. Georg Ringer uploaded patch set 1 03/27/20, 00:33

  2. Georg Ringer commented on patch set 1 03/27/20, 00:33

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/27/20, 00:46 Completed build in 13m 29s on Fri, 27 Mar, 12:46 AM Test Summary: 72717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1805

  4. Georg Ringer rebased onto patch set 2 03/27/20, 07:07

  5. TYPO3com voted on patch set 2 V +1 03/27/20, 07:20 Completed build in 13m 10s on Fri, 27 Mar, 07:20 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1809

  6. Susi Moog updated the commit message in patch set 3 03/27/20, 07:32

  7. Susi Moog voted on patch set 3 CR +1 03/27/20, 07:36

  8. Susi Moog voted on patch set 3 V +1 03/27/20, 07:44

  9. TYPO3com voted on patch set 3 V +1 03/27/20, 07:48 Completed build in 16m 19s on Fri, 27 Mar, 07:48 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1810

  10. Daniel Goerz commented on patch set 3 V -1 03/27/20, 08:11

    great, but now the frontend breaks :)
  11. Andreas Kienast commented on patch set 3 V -1 03/27/20, 08:57

    > Patch Set 3: Verified-1 > > great, but now the frontend breaks :) Can confirm, the exception "moved" to frontend
  12. Susi Moog wrote 03/27/20, 09:17

    Removed Verified+1 by Susanne Moog <look@susi.dev>
  13. Susi Moog wrote 03/27/20, 09:17

    Removed Code-Review+1 by Susanne Moog <look@susi.dev>
  14. Georg Ringer uploaded patch set 4 03/27/20, 12:39

  15. TYPO3com voted on patch set 4 V +1 03/27/20, 12:58 Completed build in 17m 21s on Fri, 27 Mar, 12:58 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1831

  16. Daniel Goerz voted on patch set 4 V +1 CR +1 03/27/20, 14:48

  17. Susi Moog voted on patch set 4 V +2 CR +2 03/27/20, 14:52

  18. Susi Moog merged patch set 5 03/27/20, 14:52