Review main Merged

63945[TASK] Move ArrayBrowser to EXT:backend

Benni Mack CR +2 V +2 Normal +138 −88 updated 03/27/20, 13:08

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 814

  1. Benni Mack uploaded patch set 1 03/27/20, 10:43

  2. Benni Mack uploaded patch set 2 03/27/20, 10:58

  3. TYPO3com voted on patch set 1 V -1 03/27/20, 11:03 Completed build in 17m 09s on Fri, 27 Mar, 11:03 AM Test Summary: 13 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1815

  4. TYPO3com voted on patch set 2 V -1 03/27/20, 11:10 Completed build in 12m 16s on Fri, 27 Mar, 11:10 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1816

  5. TYPO3com commented on patch set 2 03/27/20, 11:20 Completed build in 34m 08s on Fri, 27 Mar, 11:20 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1816

  6. TYPO3com commented on patch set 2 03/27/20, 12:07 Completed build in 1h 43m 42s on Fri, 27 Mar, 12:07 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1816

  7. Georg Ringer uploaded patch set 3 03/27/20, 12:21

  8. Andreas Kienast commented on patch set 3 CR -1 03/27/20, 12:25

    on it

    phpstan.neon:21 Unresolved

    IMO this is the wrong fix
  9. Andreas Kienast uploaded patch set 4 03/27/20, 12:26

  10. TYPO3com voted on patch set 3 V +1 03/27/20, 12:47 Completed build in 19m 32s on Fri, 27 Mar, 12:47 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1828

  11. Georg Ringer voted on patch set 4 V +1 CR +1 03/27/20, 12:50

  12. TYPO3com voted on patch set 4 V +1 03/27/20, 12:51 Completed build in 23m 55s on Fri, 27 Mar, 12:51 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1830

  13. Susi Moog voted on patch set 4 V +2 CR +2 03/27/20, 13:07

  14. Susi Moog merged patch set 5 03/27/20, 13:08