Review main Merged

63947[BUGFIX] Set `data-formengine-input-name` for disabled text fields

Andreas Kienast CR +2 V +2 Easy +9 −1 updated 03/27/20, 12:09

Commit message

Disabled input fields now contain the `data-formengine-input-name`
attribute. The slug creation is now able to determine disabled fields as
well to take them into consideration.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Andreas Kienast uploaded patch set 1 03/27/20, 11:30

  2. Frank Nägler commented on patch set 1 03/27/20, 11:39

    InputTextElement.php:101 Unresolved

    implodeAttribute() ?
  3. TYPO3com voted on patch set 1 V +1 03/27/20, 11:41 Completed build in 11m 12s on Fri, 27 Mar, 11:41 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1820

  4. Andreas Kienast uploaded patch set 2 03/27/20, 11:42

  5. Andreas Kienast uploaded patch set 3 03/27/20, 11:44

  6. Frank Nägler voted on patch set 3 V +1 CR +1 03/27/20, 11:59

  7. TYPO3com voted on patch set 2 V +1 03/27/20, 12:02 Completed build in 13m 47s on Fri, 27 Mar, 12:02 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1823

  8. TYPO3com voted on patch set 3 V +1 03/27/20, 12:07 Completed build in 18m 14s on Fri, 27 Mar, 12:07 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1824

  9. Georg Ringer voted on patch set 3 V +2 CR +2 03/27/20, 12:09

  10. Georg Ringer merged patch set 4 03/27/20, 12:09