Review main Merged

63948[TASK] Streamline TSFE internal code

Benni Mack CR +2 V +2 Easy +21 −15 updated 03/28/20, 07:22

Commit message

Some minor details are changed within TSFE.

- metaCharset is now evaluated at the same time as other TypoScript options making this option available earlier in the process
- getFromCache() and headerNoCache() now optionally receive a PSR-7 request
to evaluate serverParams from the PSR-7 request and not the superglobals

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 03/27/20, 11:41

  2. TYPO3com voted on patch set 1 V +1 03/27/20, 11:59 Completed build in 17m 45s on Fri, 27 Mar, 11:59 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1822

  3. Oliver Klee commented on patch set 1 03/27/20, 15:52

    TypoScriptFrontendController.php:1809

    Instead of having the null default value, should me make the type nullable? (Also, there should be a blank line between the @param and the @throws). What is the return type? void?

    TypoScriptFrontendController.php:1955 Unresolved

    Ditto about making the type nullable.
  4. Susi Moog voted on patch set 1 CR +1 03/27/20, 16:53

  5. Susi Moog voted on patch set 1 V +1 03/27/20, 16:59

  6. Benni Mack commented on patch set 1 03/27/20, 22:19

    TypoScriptFrontendController.php:1809 Reply Unresolved

    what do you mean? So one could call getFromCache(null) ? And I wouldn't want to change or define the return type
  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 03/28/20, 07:22

  8. Anja Leichsenring merged patch set 2 03/28/20, 07:22