63948[TASK] Streamline TSFE internal code
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 78
-
Benni Mack uploaded patch set 1 03/27/20, 11:41
-
TYPO3com voted on patch set 1 V +1 03/27/20, 11:59 Completed build in 17m 45s on Fri, 27 Mar, 11:59 AM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1822
-
Oliver Klee commented on patch set 1 03/27/20, 15:52
TypoScriptFrontendController.php:1955UnresolvedDitto about making the type nullable. -
Susi Moog voted on patch set 1 CR +1 03/27/20, 16:53
-
Susi Moog voted on patch set 1 V +1 03/27/20, 16:59
-
Benni Mack commented on patch set 1 03/27/20, 22:19
TypoScriptFrontendController.php:1809Reply Unresolvedwhat do you mean? So one could call getFromCache(null) ? And I wouldn't want to change or define the return type -
Anja Leichsenring voted on patch set 1 V +2 CR +2 03/28/20, 07:22
-
Anja Leichsenring merged patch set 2 03/28/20, 07:22
TypoScriptFrontendController.php:1809