Review main Merged

63949[TASK] Move image-related code from cObj to IMAGE

Benni Mack CR +2 V +2 Expert +979 −505 updated 03/30/20, 17:59

Commit message

The methods within ContentObjectRenderer are only needed for
rendering an IMAGE <img> tag and are moved to the right place in order
to make cObj less fat:
- cImage()
- getBorderAttr()
- getImageTagTemplate()
- getImageSourceCollection()
- linkWrap()
- getAltParam()

"imageLinkWrap()" is marked as internal for the time being, in order to refactor
this code in TYPO3 v11.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 69

  1. Benni Mack uploaded patch set 1 03/27/20, 12:04

  2. TYPO3com voted on patch set 1 V -1 03/27/20, 12:15 Completed build in 11m 17s on Fri, 27 Mar, 12:15 PM Test Summary: 5251 of 73499 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1826

  3. Benni Mack uploaded patch set 2 03/27/20, 15:20

  4. TYPO3com voted on patch set 2 V -1 03/27/20, 15:53 Completed build in 28m 32s on Fri, 27 Mar, 03:53 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1859

  5. Benni Mack uploaded patch set 3 03/27/20, 16:32

  6. TYPO3com voted on patch set 3 V +1 03/27/20, 16:45 Completed build in 12m 46s on Fri, 27 Mar, 04:45 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1865

  7. Georg Ringer voted on patch set 3 V +1 CR +1 03/30/20, 11:05

  8. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/30/20, 17:59

  9. Anja Leichsenring merged patch set 4 03/30/20, 17:59