Review main Merged

63951[BUGFIX] Allow multiline comments in SqlReader

Christian Eßl CR +2 V +2 Easy +49 −1 updated 03/27/20, 15:51

Commit message

When using c-style multiline comments in the ext_tables.sql of an
extension, the SchemaMigrator would then ignore the subsequent
"CREATE TABLE" statement, because the SqlReader also read the multiline
comments into the statement array.
This patch fixes this behaviour.
Now the following comments are possible inside ext_tables.sql:

/*
 Some comment text
 more text
*/

/* Same line c-style comment */

/* More multiline
 comments */

CREATE TABLE table1 (
    header varchar(255) DEFAULT '' NOT NULL,
    bodytext text
);

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Christian Eßl uploaded patch set 1 03/27/20, 12:24

  2. Georg Ringer commented on patch set 1 CR -1 03/27/20, 12:25

    please add those to SqlReaderTest
  3. TYPO3com voted on patch set 1 V +1 03/27/20, 12:47 Completed build in 19m 09s on Fri, 27 Mar, 12:47 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1829

  4. Daniel Goerz uploaded patch set 2 03/27/20, 15:15

  5. Daniel Goerz commented on patch set 3 03/27/20, 15:18

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 2 V +1 03/27/20, 15:35 Completed build in 20m 13s on Fri, 27 Mar, 03:35 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1855

  7. Daniel Goerz voted on patch set 3 V +1 CR +1 03/27/20, 15:37

  8. TYPO3com voted on patch set 3 V +1 03/27/20, 15:44 Completed build in 19m 32s on Fri, 27 Mar, 03:44 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1857

  9. Susi Moog voted on patch set 3 V +1 CR +1 03/27/20, 15:48

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 03/27/20, 15:51

  11. Daniel Goerz merged patch set 4 03/27/20, 15:51