Review main Merged

63953[BUGFIX] Do not render a-tag if URL is empty in link.action VH

Markus Klein CR +2 V +2 Easy +3 −0 updated 03/27/20, 14:46

Commit message

If the URL cannot be calculated by the UriBuilder an empty URL
is returned. In this case no a-tag is rendered to avoid links
with an empty href-attribute.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Johannes Kasberger +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Markus Klein uploaded patch set 1 03/27/20, 12:59

  2. TYPO3com voted on patch set 1 V +1 03/27/20, 13:20 Completed build in 20m 02s on Fri, 27 Mar, 01:20 PM Test Summary: 73013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1834

  3. Johannes Kasberger voted on patch set 1 V +1 CR +1 03/27/20, 13:46

  4. Guido Schmechel voted on patch set 1 CR +1 03/27/20, 14:03

  5. Frank Nägler voted on patch set 1 V +2 CR +2 03/27/20, 14:46

  6. Frank Nägler merged patch set 2 03/27/20, 14:46