Review main Merged

63954[TASK] Deprecate <f:widget.autocomplete> ViewHelper

Frank Nägler CR +2 V +2 Normal +57 −0 updated 03/28/20, 08:44

Commit message

The Fluid ViewHelper `<f:widget.autocomplete>` has been
marked as deprecated and will be removed in TYPO3 v11.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1015

  1. Frank Nägler uploaded patch set 1 03/27/20, 13:06

  2. Andreas Kienast updated the commit message in patch set 2 03/27/20, 13:09

  3. TYPO3com voted on patch set 1 V +1 03/27/20, 13:24 Completed build in 14m 04s on Fri, 27 Mar, 01:24 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1835

  4. TYPO3com voted on patch set 2 V +1 03/27/20, 13:32 Completed build in 22m 16s on Fri, 27 Mar, 01:32 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1837

  5. Frank Nägler uploaded patch set 3 03/27/20, 13:33

  6. TYPO3com voted on patch set 3 V +1 03/27/20, 13:51 Completed build in 13m 18s on Fri, 27 Mar, 01:51 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1841

  7. Benni Mack commented on patch set 3 CR -1 03/27/20, 15:28

    Deprecation-90856-DeprecateWidgetAutocompleteViewHelper.rst:39 Unresolved

    I recommend adding a line at a) "Description" WHY it was removed (because it depends on third-party libraries that cannot be maintained for a LTS release lifecycle) b) "Migration" -> one would / should copy it over their extension if they still need it.
  8. Frank Nägler uploaded patch set 4 03/27/20, 15:38

  9. Georg Ringer voted on patch set 4 V +1 CR +1 03/27/20, 16:00

  10. TYPO3com voted on patch set 4 V +1 03/27/20, 16:11 Completed build in 28m 31s on Fri, 27 Mar, 04:11 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1861

  11. Anja Leichsenring commented on patch set 5 03/28/20, 08:00

    Published edit on patch set 4.
  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 03/28/20, 08:01

  13. TYPO3com voted on patch set 5 V +1 03/28/20, 08:21 Completed build in 20m 55s on Sat, 28 Mar, 08:21 AM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1879

  14. Georg Ringer voted on patch set 5 V +2 CR +2 03/28/20, 08:44

  15. Georg Ringer merged patch set 6 03/28/20, 08:44