Review main Merged

63955[TASK] Improve IconViewHelper documentation

Christian Eßl CR +2 V +2 Easy +5 −5 updated 03/27/20, 15:31

Commit message

Add missing documentation to IconViewHelper and extend some of the
already existing argument descriptions.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Frank Nägler +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Christian Eßl uploaded patch set 1 03/27/20, 13:48

  2. TYPO3com voted on patch set 1 V -1 03/27/20, 14:00 Completed build in 11m 35s on Fri, 27 Mar, 01:59 PM Test Summary: 16 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1842

  3. TYPO3com voted on patch set 1 V +1 03/27/20, 14:21 Completed build in 11m 38s on Fri, 27 Mar, 02:21 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1845

  4. Daniel Goerz voted on patch set 1 V +1 CR +1 03/27/20, 14:39

  5. Guido Schmechel voted on patch set 1 CR +1 03/27/20, 14:56

  6. Daniel Goerz commented on patch set 2 03/27/20, 14:59

    Published edit on patch set 1.
  7. Susi Moog voted on patch set 2 V +1 CR +1 03/27/20, 15:01

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 03/27/20, 15:02

  9. Frank Nägler voted on patch set 2 V +1 CR +1 03/27/20, 15:14

  10. TYPO3com voted on patch set 2 V -1 03/27/20, 15:17 Completed build in 14m 30s on Fri, 27 Mar, 03:17 PM Test Summary: 1 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1853

  11. TYPO3com voted on patch set 2 V +1 03/27/20, 15:28 Completed build in 39m 42s on Fri, 27 Mar, 03:28 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1853

  12. Daniel Goerz merged patch set 3 03/27/20, 15:31