Review main Merged

63958[TASK] Replace jQuery.dataTables with tablesort

Andreas Kienast CR +2 V +2 Hard +206 −428 updated 03/30/20, 19:16

Commit message

This patch replaces DataTables with the lightweight alternative
tablesort and adjusts all usages of DataTables.

Since using DataTables with TYPO3 is neither documented nor propagated,
removing this library isn't considered as breaking change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 31

Show 11 more files

Review log 1323

  1. Andreas Kienast uploaded patch set 1 03/27/20, 15:41

  2. TYPO3com voted on patch set 1 V -1 03/27/20, 16:15 Completed build in 32m 50s on Fri, 27 Mar, 04:15 PM Test Summary: 7 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1862

  3. Andreas Kienast uploaded patch set 2 03/28/20, 19:59

  4. TYPO3com voted on patch set 2 V -1 03/28/20, 20:11 Completed build in 11m 52s on Sat, 28 Mar, 08:11 PM Test Summary: 7 of 73416 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1903

  5. Andreas Kienast uploaded patch set 3 03/28/20, 21:34

  6. TYPO3com voted on patch set 3 V -1 03/28/20, 21:48 Completed build in 14m 37s on Sat, 28 Mar, 09:48 PM Test Summary: 2 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1915

  7. Andreas Kienast uploaded patch set 4 03/28/20, 21:52

  8. TYPO3com voted on patch set 4 V -1 03/28/20, 22:05 Completed build in 13m 26s on Sat, 28 Mar, 10:05 PM Test Summary: 2 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1917

  9. Andreas Kienast uploaded patch set 5 03/29/20, 06:39

  10. TYPO3com voted on patch set 5 V -1 03/29/20, 06:55 Completed build in 15m 10s on Sun, 29 Mar, 06:55 AM Test Summary: 7 of 73535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1920

  11. TYPO3com voted on patch set 5 V +1 03/29/20, 07:06 Completed build in 41m 28s on Sun, 29 Mar, 07:06 AM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1920

  12. Andreas Kienast uploaded patch set 6 03/30/20, 15:48

  13. Andreas Kienast uploaded patch set 7 03/30/20, 15:53

  14. Andreas Kienast commented on patch set 7 CR -1 03/30/20, 15:57

    checking something...
  15. TYPO3com voted on patch set 6 V +1 03/30/20, 16:03 Completed build in 15m 00s on Mon, 30 Mar, 04:03 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1973

  16. Andreas Kienast uploaded patch set 8 03/30/20, 16:06

  17. TYPO3com voted on patch set 7 V +1 03/30/20, 16:07 Completed build in 13m 43s on Mon, 30 Mar, 04:07 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1974

  18. Andreas Kienast uploaded patch set 9 03/30/20, 16:08

  19. TYPO3com voted on patch set 8 V -1 03/30/20, 16:18 Completed build in 11m 51s on Mon, 30 Mar, 04:18 PM Test Summary: 73041 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1975

  20. TYPO3com voted on patch set 9 V +1 03/30/20, 16:23 Completed build in 14m 36s on Mon, 30 Mar, 04:23 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1976

  21. Georg Ringer voted on patch set 9 V +1 CR +1 03/30/20, 18:10

  22. Benni Mack voted on patch set 9 V +2 CR +2 03/30/20, 19:16

  23. Benni Mack merged patch set 10 03/30/20, 19:16