63959[BUGFIX] Hide InlineControlContainer buttons, if no edit permissions
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1215
-
Christian Eßl uploaded patch set 1 03/27/20, 21:27
-
Christian Eßl commented on patch set 1 03/27/20, 21:28
See https://forge.typo3.org/issues/78860?issue_count=119&issue_position=6&next_issue_id=77673&prev_issue_id=84185#note-2 for explanation and how to reproduce the problem. -
TYPO3com voted on patch set 1 V +1 03/27/20, 21:39 Completed build in 11m 37s on Fri, 27 Mar, 09:39 PM Test Summary: 73043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1874
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 03/28/20, 07:41
-
Benni Mack updated the commit message in patch set 2 05/25/20, 18:45
-
TYPO3com voted on patch set 2 V +1 05/25/20, 19:50 Completed build in 1h 01m 17s on Mon, 25 May, 07:50 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3537
-
Mathias Brodala commented on patch set 2 05/26/20, 06:37
InlineControlContainer.php:683UnresolvedThere should be an early return in case of an admin to skip all the remaining logic for regular users. -
Anja Leichsenring uploaded patch set 3 05/26/20, 16:14
-
TYPO3com voted on patch set 3 V +1 05/26/20, 18:03 Completed build in 48m 13s on Tue, 26 May, 06:03 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3572
-
Benni Mack voted on patch set 3 CR +1 06/04/20, 19:23
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 06/20/20, 07:00
-
Daniel Goerz commented on patch set 3 06/29/20, 19:01
InlineControlContainer.php:511UnresolvedHmm I dont really like how there is just nothing but the label for the field now. I would consider the following things all further improvements: * The label is also not rendered * The button is still rendered but disabled * A short message is rendered "You dont have permission to edit this field" or something like that. -
Oli Bartsch commented on patch set 3 V -1 09/02/20, 15:38
IMO This doesn't solve the issue in total. If a FAL is already added in page properties, the user which is lacking content edit permissions is still not able to open the page properties any more because the permission is checked in DatabaseUserPermissionCheck for the FAL field and an exception is thrown in this case. -
Anja Leichsenring commented on patch set 3 V -1 CR 0 09/02/20, 17:34
agreeing with both Daniel and Oliver. The patch is technically correct and works as advertised, but it looks strange without the buttons (which I would accept) and it blocks the user from opening a page that has relations on it, which is bad. So if there would be a possibility to render the relation part read only, but letting the record be opened, that would be an acceptable solution. -
Benni Mack abandoned the change 11/04/21, 12:10
abandoned for the time being due to lack of activity