Review main Merged

63963[BUGFIX] Use correct slug for access restricted translated pages

Christian Eßl CR +2 V +2 Normal +80 −0 updated 05/06/20, 14:56

Commit message

Access restricted, translated pages currently always have the slug from the
default language instead of their translated slug in the frontend.
To generate correct urls, while using the "linkAccessRestrictedPages"
option, the $disableGroupAccessCheck parameter needs to also take into
account for
 * PageRepository::getPageOverlay()
when setting the option in PageRepository::getPage().

This "hack" is currently similar to what HMENU is doing, however
this public property should not be used with the Context API instead.

This change however needs more refactoring on the Context API,
which is why this solution is chosen for the time being (and also
for v9 backport).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 3

Files 3

Review log 1418

  1. Christian Eßl uploaded patch set 1 03/28/20, 09:41

  2. Christian Eßl updated the commit message in patch set 2 03/28/20, 09:44

  3. TYPO3com voted on patch set 1 V -1 03/28/20, 09:55 Completed build in 14m 12s on Sat, 28 Mar, 09:55 AM Test Summary: 73069 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1886

  4. TYPO3com voted on patch set 2 V +1 03/28/20, 10:00 Completed build in 15m 48s on Sat, 28 Mar, 10:00 AM Test Summary: 73071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1887

  5. Markus Klein voted on patch set 2 CR +1 04/15/20, 21:48

  6. Benni Mack commented on patch set 2 CR -1 04/21/20, 19:43

    I have a better idea which allows to modify other aspects as well, let me see if I can push something!
  7. Helmut Hummel commented on patch set 2 04/28/20, 15:06

    How is this one different from https://review.typo3.org/c/Packages/TYPO3.CMS/+/60326 (except that test are added of course) :)
  8. Benni Mack commented on patch set 2 04/28/20, 15:09

    > Patch Set 2: > > How is this one different from https://review.typo3.org/c/Packages/TYPO3.CMS/+/60326 > (except that test are added of course) :) :D good question! Btw... I would rather make use of the "frontend.user" aspect, and set up a new one to disable the aspect in this method (and re-set it afterwards) because this way we can finally make use of the Context API in this class instead of adding another method argument - that's what I'm currently trying to set up - this way where_hid_del can go away as well.
  9. Jonas Eberle commented on patch set 2 04/28/20, 19:00

    PageRepository::where_groupAccess was set to '' for linking to access restricted pages and respected in getPageOverlaysForLanguageUids(). We should either get rid of that completely OR use the newly introduced parameter from this patch throughout. Here is another consumer of the (probably older, historical, but working) 'where_groupAcess' approach: AbstractMenuContentObject::makeMenu() - I made https://review.typo3.org/c/Packages/TYPO3.CMS/+/64318 with the intention to restore that behaviour - that patch only targets the TMENU/MenuProcessor though as where_groupAcess is not set from somewhere else any more.
  10. Benni Mack uploaded patch set 3 05/02/20, 19:15

  11. TYPO3com voted on patch set 3 V -1 05/02/20, 19:16 Completed build in 24s on Sat, 2 May, 07:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3170

  12. Benni Mack uploaded patch set 4 05/02/20, 19:17

  13. Benni Mack commented on patch set 4 05/02/20, 19:19

    @All: This change is now different in two ways than before & Helmut's approach: * We do not need to introduce new method arguments in various places * We only remove the FrontendGroup restriction and not the others (IIRC) However, that being said I still consider this solution ugly due to this stupid public property instead of Using Context API.
  14. TYPO3com voted on patch set 4 V +1 05/02/20, 19:28 Completed build in 11m 10s on Sat, 2 May, 07:28 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3171

  15. Jonas Eberle voted on patch set 4 V +1 CR +1 05/02/20, 19:58

  16. Helmut Hummel voted on patch set 4 CR +1 05/05/20, 14:04

  17. Benni Mack voted on patch set 4 V +2 CR +2 05/06/20, 14:56

  18. Benni Mack merged patch set 5 05/06/20, 14:56