63965[TASK] Move EXT:form inline JS from template to controller
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1317
-
Claus Due uploaded patch set 1 03/28/20, 11:18
-
TYPO3com voted on patch set 1 V +1 03/28/20, 11:30 Completed build in 11m 23s on Sat, 28 Mar, 11:30 AM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1891
-
Georg Ringer commented on patch set 1 03/28/20, 18:22
and what with 9.5? -
Benjamin Franzke commented on patch set 1 CR -1 05/12/20, 20:02
FormEditor.html:28Can we describe the reason why this code is Fluid 3.x incompatible in the commit message? Is it because of nested curly braces? This smells like something that Fluid 3.x should support. Inline javascript is of course discouraged, still, the templating should be able to output this. If it's really about curly braces then some sort of escaping would be needed. -
Claus Due commented on patch set 1 05/13/20, 07:32
FormEditor.html:28Reply UnresolvedBottom line is, if you want this to work with Fluid 2.x and 3.x at the same time, then this is the way it has to happen. Fluid 3.x has a way to escape things (prefixing the curly braces with a backslash) but that doesn't work the same on 2.x. And 2.x of course has its own way which is centered around breaking regexp detection. -
Claus Due updated the commit message in patch set 2 06/02/20, 12:03
-
TYPO3com voted on patch set 2 V +1 06/02/20, 12:14 Completed build in 10m 52s on Tue, 2 Jun, 12:14 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3743
-
Sascha Egerer commented on patch set 2 CR +1 05/11/21, 05:07
Would be very cool to get that merged -
waldhacker uploaded patch set 3 08/11/21, 09:48
-
core-ci voted on patch set 3 V -1 08/11/21, 10:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14568
-
waldhacker uploaded patch set 4 08/11/21, 10:20
-
core-ci voted on patch set 4 V +1 08/11/21, 10:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14572
-
waldhacker voted on patch set 4 V +1 CR +1 08/11/21, 10:36
-
Björn Jacob voted on patch set 4 V +1 CR +1 08/11/21, 10:50
-
waldhacker voted on patch set 4 V +2 CR +2 08/11/21, 10:55
-
waldhacker merged patch set 5 08/11/21, 10:56
-
Oliver Hader commented on patch set 5 10/22/21, 20:51
Just stumbled over this: Just WOW!